docker-dev: Make the docker-compose actually composable!
ClosedPublic
Actions

Authored by douardda on Dec 13 2018, 3:07 PM.

Details

Reviewers

ardumont
vlorentz

Group Reviewers

Reviewers

Commits

rDENVe6cd16ec4f57: refactor a bit
rCDFDe6cd16ec4f57: refactor a bit

Summary

move every docker build material in a per-container dedicated directory
use entrypoint.sh files as entrypoints
simplify a lot the Dockerfile: we only pip install what's necessary, the possibility of using swh packages from sources is done by detecting and installing every repo found in /src/swh-*. It's the responsibility of the user to mount local source directories via docker volumes.
rewrite the docker-compose file accordingly, using env vars when needed.

Related T1443

Diff Detail

Repository

rCDFD Dockerfiles for developers

Branch

fixstuff

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 3006
Build 3839: arc lint + arc unit

Event Timeline

douardda created this revision.Dec 13 2018, 3:07 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 13 2018, 3:07 PM

Harbormaster completed remote builds in B3005: Diff 2578.Dec 13 2018, 3:07 PM

When is the "init" "target" of dockerfiles/swh-storage/entrypoint.sh called?

If it's not automatic, it should be documented in the README.

dockerfiles/swh-storage/Dockerfile
12	this comment should be removed

ardumont added a subscriber: ardumont.Dec 13 2018, 3:12 PM

ardumont added inline comments.

dockerfiles/swh-objstorage/Dockerfile
7	Duplicated steps.

There are some typos and all but i'm fine with fixing it myself.

Thanks!

This revision is now accepted and ready to land.Dec 13 2018, 3:13 PM

Also, the makefile could either go away or be refactored to use docker-compose build all over the place ;)

Also, the makefile could either go away or be refactored to use docker-compose build all over the place ;)

I like makefile so i'm for 2 ;)

In D811#17198, @vlorentz wrote:

When is the "init" "target" of dockerfiles/swh-storage/entrypoint.sh called?

If it's not automatic, it should be documented in the README.

Agreed, will do

fix typos and more doc in the readme

Harbormaster completed remote builds in B3006: Diff 2579.Dec 13 2018, 3:28 PM

vlorentz accepted this revision.Dec 13 2018, 3:29 PM

ardumont accepted this revision.Dec 13 2018, 3:31 PM

ardumont added inline comments.