This allows restoring objects as-is, so they match checksums;
even when the parser was lossy.
Finally makes use of what we implemented in T3753
Details
Details
- Reviewers
olasd ardumont - Group Reviewers
Reviewers - Maniphest Tasks
- T3753: Store original git manifests
- Commits
- rDVAUcc209760144d: git_bare: Use raw_manifest when available
Diff Detail
Diff Detail
- Repository
- rDVAU Software Heritage Vault
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 26477 Build 41402: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 41401: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D7067 (id=25646)
Rebasing onto 1da8cbe0a9...
Current branch diff-target is up to date.
Changes applied before test
commit b8d825325d84a4417b6a71aabb1d591d347772e0
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Wed Feb 2 18:31:06 2022 +0100
git_bare: Use raw_manifest when available
This allows restoring objects as-is, so they match checksums;
even when the parser was lossy.See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/201/ for more details.
Comment Actions
lgtm
Don't this modification requires a bump in swh.storage and/or swh.model dependency?
Comment Actions
nope, we don't use a new future of swh-storage, and the current swh-model requirements (3.0.0) already had raw_manifest
Comment Actions
Build has FAILED
Patch application report for D7067 (id=25798)
Rebasing onto cbad3b9da8...
First, rewinding head to replay your work on top of it... Fast-forwarded diff-target to base-revision-203-D7067.
Changes applied before test
Link to build: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/203/
See console output for more information: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/203/console