iso8601 is good enough, according to D6911#inline-49609
Also fix incorrect type annotations and test.
Depends on D6911.
Details
Details
- Reviewers
anlambert - Group Reviewers
Reviewers - Commits
- rDLDSVN93b4f2fdd878: Remove dependency on dateutil
Diff Detail
Diff Detail
- Repository
- rDLDSVN Subversion (SVN) loader
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
Patch application report for D6912 (id=25053)
Could not rebase; Attempt merge onto 1b13c5c19e...
Updating 1b13c5c..93b4f2f Fast-forward requirements.txt | 1 - swh/loader/svn/converters.py | 20 ++++++++++++-------- swh/loader/svn/svn.py | 2 +- swh/loader/svn/tests/test_converters.py | 4 ++-- swh/loader/svn/tests/test_utils.py | 17 ----------------- swh/loader/svn/utils.py | 29 +---------------------------- 6 files changed, 16 insertions(+), 57 deletions(-)
Changes applied before test
commit 93b4f2fdd87895ef2f893631cbc03c73def2ab56
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Tue Jan 11 14:02:37 2022 +0100
Remove dependency on dateutil
iso8601 is good enough.
Also fix incorrect type annotations and test.
commit 3c9cbceb9ede842fd5c312898e4e9ad85c30e073
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Tue Jan 11 12:57:46 2022 +0100
Remove strdate_to_timestamp
It duplicates TimestampWithTimezone.from_datetime().See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/228/ for more details.