Page MenuHomeSoftware Heritage
Differential D785

Start removing mocks for the mimetype indexer.
ClosedPublic
Actions

Authored by vlorentz on Dec 6 2018, 4:44 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Maniphest Tasks
T1307: Remove mock storages used in tests.
Commits
rDCIDXed4e96bde78f: Start removing mocks for the mimetype indexer.
Summary

Range tests are missing.

(Includes commits from D783)

Diff Detail

Repository
rDCIDX Metadata indexer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Dec 6 2018, 4:44 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptDec 6 2018, 4:44 PM
vlorentz added a parent revision: D783: rm ctags mocks + add ctags to idx db + fix doc..Dec 6 2018, 4:47 PM
swh-public-ci added a subscriber: swh-public-ci.Dec 6 2018, 4:47 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/128/ for more details.

Harbormaster completed remote builds in B2899: Diff 2477.Dec 6 2018, 4:47 PM
vlorentz mentioned this in D786: Add content_fossology_license_get_range + Remove mock from non-range tests..Dec 6 2018, 4:52 PM
vlorentz added a child revision: D786: Add content_fossology_license_get_range + Remove mock from non-range tests..Dec 6 2018, 4:52 PM
vlorentz retitled this revision from Start remove mocks for the mimetype indexer. to Start removing mocks for the mimetype indexer..
vlorentz edited the summary of this revision. (Show Details)
vlorentz updated this revision to Diff 2484.Dec 7 2018, 10:06 AM
  • Rebase
Harbormaster failed remote builds in B2906: Diff 2484!Dec 7 2018, 10:07 AM
swh-public-ci added a comment.Dec 7 2018, 10:07 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/133/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/133/console

vlorentz updated this revision to Diff 2485.Dec 7 2018, 10:07 AM
  • rebase
swh-public-ci added a comment.Dec 7 2018, 10:11 AM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/134/ for more details.

Harbormaster completed remote builds in B2907: Diff 2485.Dec 7 2018, 10:11 AM
vlorentz updated this revision to Diff 2489.Dec 7 2018, 11:39 AM
  • display only relevant changes.
Harbormaster failed remote builds in B2911: Diff 2489!Dec 7 2018, 11:39 AM
swh-public-ci added a comment.Dec 7 2018, 11:39 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/138/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/138/console

vlorentz updated this revision to Diff 2490.Dec 7 2018, 11:40 AM
  • oops nope
Harbormaster completed remote builds in B2912: Diff 2490.Dec 7 2018, 11:43 AM
swh-public-ci added a comment.Dec 7 2018, 11:43 AM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/139/ for more details.

ardumont accepted this revision.Dec 7 2018, 12:26 PM
This revision is now accepted and ready to land.Dec 7 2018, 12:26 PM
Closed by commit rDCIDXed4e96bde78f: Start removing mocks for the mimetype indexer. (authored by vlorentz). · Explain WhyDec 7 2018, 1:55 PM
This revision was automatically updated to reflect the committed changes.
vlorentz added a task: T1307: Remove mock storages used in tests..Dec 7 2018, 5:13 PM

Revision Contents
Changeset List

PathSize
swh/
indexer/
storage/
52 lines
tests/
storage/
16 lines
12 lines

Diff 2492

View Options

swh/indexer/storage/in_memory.py

Loading...
View Options

swh/indexer/tests/storage/test_in_memory.py

Loading...
View Options

swh/indexer/tests/test_mimetype.py

Loading...
About · Developer information · Legal