Page MenuHomeSoftware Heritage
Differential D790

Add in-mem storage for intrinsic metadata.
ClosedPublic
Actions

Authored by vlorentz on Dec 7 2018, 1:50 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Maniphest Tasks
T1307: Remove mock storages used in tests.
Commits
rDCIDXa8bd3809b800: Add in-mem storage for intrinsic metadata.
Summary

(Includes commits from D789)

Diff Detail

Repository
rDCIDX Metadata indexer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Dec 7 2018, 1:50 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptDec 7 2018, 1:50 PM
vlorentz added a parent revision: D789: Remove languages mock..Dec 7 2018, 1:50 PM
Harbormaster failed remote builds in B2913: Diff 2491!Dec 7 2018, 1:51 PM
swh-public-ci added a subscriber: swh-public-ci.Dec 7 2018, 1:51 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/140/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/140/console

vlorentz updated this revision to Diff 2498.Dec 7 2018, 2:27 PM
  • rebase
Harbormaster failed remote builds in B2919: Diff 2498!Dec 7 2018, 2:28 PM
swh-public-ci added a comment.Dec 7 2018, 2:28 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/144/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/144/console

vlorentz updated this revision to Diff 2499.Dec 7 2018, 2:28 PM
  • remove useless function
Harbormaster failed remote builds in B2920: Diff 2499!Dec 7 2018, 2:29 PM
swh-public-ci added a comment.Dec 7 2018, 2:29 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/145/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/145/console

ardumont added a subscriber: ardumont.Dec 7 2018, 2:38 PM
ardumont added inline comments.
swh/indexer/storage/in_memory.py
656

why not merge those 2 lines?

for (_, data) in results[:limit]:
vlorentz updated this revision to Diff 2501.Dec 7 2018, 2:46 PM
  • Merge lines.
vlorentz updated this revision to Diff 2502.Dec 7 2018, 2:47 PM
  • rebase
vlorentz marked an inline comment as done.Dec 7 2018, 2:47 PM
Harbormaster failed remote builds in B2922: Diff 2501!Dec 7 2018, 2:47 PM
swh-public-ci added a comment.Dec 7 2018, 2:47 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/147/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/147/console

Harbormaster failed remote builds in B2923: Diff 2502!Dec 7 2018, 2:48 PM
swh-public-ci added a comment.Dec 7 2018, 2:48 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/148/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/148/console

ardumont accepted this revision.Dec 7 2018, 2:49 PM
This revision is now accepted and ready to land.Dec 7 2018, 2:49 PM
vlorentz updated this revision to Diff 2508.Dec 7 2018, 5:06 PM
  • rebase
Closed by commit rDCIDXa8bd3809b800: Add in-mem storage for intrinsic metadata. (authored by vlorentz). · Explain WhyDec 7 2018, 5:06 PM
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B2929: Diff 2508!Dec 7 2018, 5:07 PM
swh-public-ci added a comment.Dec 7 2018, 5:07 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/152/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/152/console

vlorentz added a task: T1307: Remove mock storages used in tests..Dec 7 2018, 5:13 PM

Revision Contents
Changeset List

PathSize
swh/
indexer/
storage/
2 lines
100 lines
tests/
storage/
28 lines

Diff 2509

View Options

swh/indexer/storage/__init__.py

Loading...
View Options

swh/indexer/storage/in_memory.py

Loading...
View Options

swh/indexer/tests/storage/test_in_memory.py

Loading...
About · Developer information · Legal