Also fix hash types and add type checks.
Duplicate of D787, which I somehow messed up?
Paths
| Differential D788 Authored by vlorentz on Dec 7 2018, 10:15 AM.
Details
Summary Also fix hash types and add type checks. Duplicate of D787, which I somehow messed up?
Diff Detail
Event TimelineHerald added a reviewer: Reviewers. · View Herald TranscriptDec 7 2018, 10:15 AM2018-12-07 10:15:31 (UTC+1) Harbormaster failed remote builds in B2908: Diff 2486!Dec 7 2018, 10:15 AM2018-12-07 10:15:52 (UTC+1) Comment Actions Build has FAILED Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/135/ vlorentz added a child revision: D789: Remove languages mock..Dec 7 2018, 10:28 AM2018-12-07 10:28:17 (UTC+1) Harbormaster failed remote builds in B2910: Diff 2488!Dec 7 2018, 10:46 AM2018-12-07 10:46:43 (UTC+1) Comment Actions Build has FAILED Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/137/ ardumont added inline comments. This revision is now accepted and ready to land.Dec 7 2018, 12:34 PM2018-12-07 12:34:51 (UTC+1) This revision now requires changes to proceed.Dec 7 2018, 12:35 PM2018-12-07 12:35:27 (UTC+1) Comment Actions Well, i requested changes only because i messed up. I did not have time to read it yet. Comment Actions Build is green Harbormaster completed remote builds in B2917: Diff 2496.Dec 7 2018, 2:26 PM2018-12-07 14:26:40 (UTC+1)
Comment Actions Build is green Harbormaster completed remote builds in B2921: Diff 2500.Dec 7 2018, 2:47 PM2018-12-07 14:47:33 (UTC+1) This revision is now accepted and ready to land.Dec 7 2018, 2:48 PM2018-12-07 14:48:45 (UTC+1) Closed by commit rDCIDXf8a2201906e8: Remove mocks from range tests of mimetype and license indexers. (authored by vlorentz). · Explain WhyDec 7 2018, 5:02 PM2018-12-07 17:02:29 (UTC+1) This revision was automatically updated to reflect the committed changes. Harbormaster failed remote builds in B2925: Diff 2504!Dec 7 2018, 5:02 PM2018-12-07 17:02:40 (UTC+1) Comment Actions Build has FAILED Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/150/
Revision Contents
Diff 2488 swh/indexer/fossology_license.py
swh/indexer/indexer.py
swh/indexer/storage/__init__.py
swh/indexer/storage/in_memory.py
|
Don't we want to keep the original docstring as well here (@functools.wraps)?