Differential D6849

swh.loader.cvs.tasks: Fix parameter uses to the ones needed
ClosedPublic
Actions

Authored by ardumont on Dec 16 2021, 10:51 AM.

Details

Reviewers

stsp

Group Reviewers

Reviewers

Maniphest Tasks

T3788: staging: Deploy cvs loader v0.1

Commits

rDLDCVSf191158dc4ef: swh.loader.cvs.tasks: Fix parameter uses to the ones needed

Summary

The existing code was probably made out of the svn loader and got never changed. This
drops the inexistant parameters and keep only the one needed.

This also adds coverage to the module.

Related to T3788

Diff Detail

Repository

rDLDCVS CVS Loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 25669
Build 40131: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 40130: arc lint + arc unit

Event Timeline

ardumont created this revision.Dec 16 2021, 10:51 AM

Build has FAILED

Patch application report for D6849 (id=24826)

Rebasing onto ce656fdebc...

Current branch diff-target is up to date.

Changes applied before test

commit ab529565af87f76b56b90d7ac794f84bb1d16e6e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Dec 16 10:49:13 2021 +0100

    swh.loader.cvs.tasks: Fix parameter uses to the ones needed
    
    The existing code was probably made out of the svn loader and got never changed. This
    drops the inexistant parameters and keep only the one needed.
    
    This also adds coverage to the module.
    
    Related to T3788

Link to build: https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/84/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/84/console

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 16 2021, 10:52 AM

Harbormaster failed remote builds in B25669: Diff 24826!

Check the build works (without mypy breaking stuff)

Build is green

Patch application report for D6849 (id=24830)

Rebasing onto ce656fdebc...

Current branch diff-target is up to date.

Changes applied before test

commit f191158dc4efa1d8aca16db0a187afa605f24d81
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Dec 16 10:49:13 2021 +0100

    swh.loader.cvs.tasks: Fix parameter uses to the ones needed
    
    The existing code was probably made out of the svn loader and got never changed. This
    drops the inexistant parameters and keep only the one needed.
    
    This also adds coverage to the module.
    
    Related to T3788

See https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/85/ for more details.

Harbormaster completed remote builds in B25673: Diff 24830.Dec 16 2021, 11:23 AM

ardumont requested review of this revision.Dec 16 2021, 11:23 AM

stsp accepted this revision.Dec 16 2021, 11:33 AM

This revision is now accepted and ready to land.Dec 16 2021, 11:33 AM

Closed by commit rDLDCVSf191158dc4ef: swh.loader.cvs.tasks: Fix parameter uses to the ones needed (authored by ardumont). · Explain WhyDec 16 2021, 11:33 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDCVSf191158dc4ef: swh.loader.cvs.tasks: Fix parameter uses to the ones needed.