Paths

Table of Contentst

Differential D6776

Add attribute TimestampWithTimezone.offset_bytes, to store raw Git offsets
ClosedPublic
Actions

Authored by vlorentz on Dec 7 2021, 4:51 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Maniphest Tasks

T3752: Store/represent time offsets as strings

Commits

rDMODc32290481cbb: Add attribute TimestampWithTimezone.offset_bytes, to store raw Git offsets

Summary

For now it is filled from 'offset' and 'negative_utc', but it will replace them
in a future commit.

This is to simplify and add support for more 'weird' offsets we do not currently
support.

First step to resolve T3752.

Diff Detail

Repository

rDMOD Data model

Branch

weird-git

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 25486
Build 39840: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 39839: arc lint + arc unit

Event Timeline

vlorentz created this revision.Dec 7 2021, 4:51 PM

Build is green

Patch application report for D6776 (id=24595)

Rebasing onto c525484e47...

First, rewinding head to replay your work on top of it...
Applying: Add attribute TimestampWithTimezone.offset_bytes, to store raw Git offsets

Changes applied before test

commit a5c27adb1170d8ed5670bfe6ee54511fda0b6c12
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Dec 7 16:50:38 2021 +0100

    Add attribute TimestampWithTimezone.offset_bytes, to store raw Git offsets
    
    For now it is filled from 'offset' and 'negative_utc', but it will replace them
    in a future commit.
    
    This is to simplify and add support for more 'weird' offsets we do not currently
    support.

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/415/ for more details.

Harbormaster completed remote builds in B25456: Diff 24595.Dec 7 2021, 4:53 PM

vlorentz requested review of this revision.Dec 7 2021, 4:53 PM

I think the backwards-compatibility offset bytes should be +HHMM rather than just a serialization of int(offset)?

omg you're right, I confused it with the timestamp field

implement the right format

That makes much more sense!

This revision is now accepted and ready to land.Dec 8 2021, 3:11 PM

Build is green

Patch application report for D6776 (id=24627)

Could not rebase; Attempt merge onto c525484e47...

Updating c525484..6388395
Fast-forward
 swh/model/hypothesis_strategies.py  | 25 +++++++++++--------
 swh/model/model.py                  | 50 ++++++++++++++++++++++++++++++++++++-
 swh/model/tests/test_identifiers.py | 19 ++++++++++++--
 swh/model/tests/test_model.py       | 12 ++++++---
 4 files changed, 89 insertions(+), 17 deletions(-)

Changes applied before test

commit 63883957079247966fe6ab0dd7ac36b137b5280d
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Dec 7 16:50:38 2021 +0100

    Add attribute TimestampWithTimezone.offset_bytes, to store raw Git offsets
    
    For now it is filled from 'offset' and 'negative_utc', but it will replace them
    in a future commit.
    
    This is to simplify and add support for more 'weird' offsets we do not currently
    support.

commit b065c139c8ab177b52f8113be12bae9c09fa5873
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Dec 8 12:27:28 2021 +0100

    hypothesis_strategies: Ensure to generate valid directory entry name (again)

commit a2f4c79958bec48b21dcf7e0adf2f2dc78eac1d3
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Dec 8 12:22:01 2021 +0100

    Revert "hypothesis_strategies: Ensure to generate valid directory entry name"
    
    This reverts commit c525484e473720ffcde89534d3ba89093bc8b016.

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/419/ for more details.

Harbormaster completed remote builds in B25486: Diff 24627.Dec 8 2021, 3:11 PM

rebase

Build is green

Patch application report for D6776 (id=24632)

Could not rebase; Attempt merge onto f6e0a289ef...

Updating f6e0a28..c322904
Fast-forward
 swh/model/hypothesis_strategies.py  | 25 +++++++++++--------
 swh/model/model.py                  | 50 ++++++++++++++++++++++++++++++++++++-
 swh/model/tests/test_identifiers.py | 19 ++++++++++++--
 swh/model/tests/test_model.py       | 12 ++++++---
 4 files changed, 89 insertions(+), 17 deletions(-)

Changes applied before test

commit c32290481cbb6920da96ecc51fae96f3f0356bfe
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Dec 7 16:50:38 2021 +0100

    Add attribute TimestampWithTimezone.offset_bytes, to store raw Git offsets
    
    For now it is filled from 'offset' and 'negative_utc', but it will replace them
    in a future commit.
    
    This is to simplify and add support for more 'weird' offsets we do not currently
    support.

commit 52d6e0a5065a550cebd89bc5e9ecb2ed14bf7119
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Dec 8 12:27:28 2021 +0100

    hypothesis_strategies: Ensure to generate valid directory entry name (again)

commit 4803d786d911848600ccab531071fbbbbe499aaa
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Dec 8 12:22:01 2021 +0100

    Revert "hypothesis_strategies: Ensure to generate valid directory entry name"
    
    This reverts commit c525484e473720ffcde89534d3ba89093bc8b016.

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/422/ for more details.

Harbormaster completed remote builds in B25491: Diff 24632.Dec 8 2021, 3:49 PM

Closed by commit rDMODc32290481cbb: Add attribute TimestampWithTimezone.offset_bytes, to store raw Git offsets (authored by vlorentz). · Explain WhyDec 8 2021, 5:16 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDMODc32290481cbb: Add attribute TimestampWithTimezone.offset_bytes, to store raw Git offsets.