maven: Pass the base URL of the Maven instance to the loader
ClosedPublic
Actions

Authored by vlorentz on Dec 7 2021, 1:51 PM.

Details

Reviewers

borisbaldassari
ardumont

Group Reviewers

Reviewers

Commits

rDLSfa7ecc8fbdf0: maven: Pass the base URL of the Maven instance to the loader

Summary

I would like to use it as the metadata authority URI in the loader,
instead of '{p_url.scheme}://{p_url.netloc}/', which I do not think
is accurate, as it is possible to have multiple Maven instances at
the same netloc.

Diff Detail

Repository

rDLS Listers

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Dec 7 2021, 1:51 PM

Build is green

Patch application report for D6770 (id=24564)

Rebasing onto 15fa84cf7e...

Current branch diff-target is up to date.

Changes applied before test

commit fa7ecc8fbdf0afb54fad0c3acec58c3f646758b2
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Dec 7 13:51:00 2021 +0100

    maven: Pass the base URL of the Maven instance to the loader
    
    I would like to use it as the metadata authority URI in the loader,
    instead of '{p_url.scheme}://{p_url.netloc}/', which I do not think
    is accurate, as it is possible to have multiple Maven instances at
    the same netloc.

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/431/ for more details.

Harbormaster completed remote builds in B25436: Diff 24564.Dec 7 2021, 1:54 PM

vlorentz requested review of this revision.Dec 7 2021, 1:54 PM

vlorentz added a child revision: D6771: maven: Use the instance base_url as metadata authority URL.Dec 7 2021, 2:14 PM

Makes sense. LGTM.
Thanks @vlorentz for the improvement.
(oh, I didn't click on submit, sorry)

This revision is now accepted and ready to land.Dec 8 2021, 10:31 AM

ardumont accepted this revision.Dec 8 2021, 10:33 AM

Closed by commit rDLSfa7ecc8fbdf0: maven: Pass the base URL of the Maven instance to the loader (authored by vlorentz). · Explain WhyDec 8 2021, 11:05 AM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDLSfa7ecc8fbdf0: maven: Pass the base URL of the Maven instance to the loader.