I would like to use it as the metadata authority URI in the loader,
instead of '{p_url.scheme}://{p_url.netloc}/', which I do not think
is accurate, as it is possible to have multiple Maven instances at
the same netloc.
Details
Details
- Reviewers
borisbaldassari ardumont - Group Reviewers
Reviewers - Commits
- rDLSfa7ecc8fbdf0: maven: Pass the base URL of the Maven instance to the loader
Diff Detail
Diff Detail
- Repository
- rDLS Listers
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 25436 Build 39764: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 39763: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D6770 (id=24564)
Rebasing onto 15fa84cf7e...
Current branch diff-target is up to date.
Changes applied before test
commit fa7ecc8fbdf0afb54fad0c3acec58c3f646758b2 Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Tue Dec 7 13:51:00 2021 +0100 maven: Pass the base URL of the Maven instance to the loader I would like to use it as the metadata authority URI in the loader, instead of '{p_url.scheme}://{p_url.netloc}/', which I do not think is accurate, as it is possible to have multiple Maven instances at the same netloc.
See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/431/ for more details.
Comment Actions
Makes sense. LGTM.
Thanks @vlorentz for the improvement.
(oh, I didn't click on submit, sorry)