Page MenuHomeSoftware Heritage
Differential D779

Use the in-mem storage.
ClosedPublic
Actions

Authored by vlorentz on Dec 5 2018, 1:41 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Maniphest Tasks
T1307: Remove mock storages used in tests.
Commits
rDLDDIR4aeac0ea7845: Use the in-mem storage.

Diff Detail

Repository
rDLDDIR Directory Loader
Branch
inmem-storage
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2856
Build 3608: tox-on-jenkinsJenkins
Build 3607: arc lint + arc unit

Event Timeline

vlorentz created this revision.Dec 5 2018, 1:41 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptDec 5 2018, 1:41 PM
vlorentz added a task: T1307: Remove mock storages used in tests..Dec 5 2018, 1:42 PM
Harbormaster completed remote builds in B2856: Diff 2449.Dec 5 2018, 1:42 PM
swh-public-ci added a subscriber: swh-public-ci.Dec 5 2018, 1:42 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDDIR/job/tox/7/ for more details.

ardumont accepted this revision.Dec 5 2018, 2:01 PM
ardumont added a subscriber: ardumont.
ardumont added inline comments.
swh/loader/dir/tests/test_loader.py
55

That's not needed.

This revision is now accepted and ready to land.Dec 5 2018, 2:01 PM
vlorentz marked an inline comment as done.Dec 5 2018, 2:11 PM
vlorentz added inline comments.
swh/loader/dir/tests/test_loader.py
55

It is. BaseDirLoaderTest.setUp extracts a tarball.

Closed by commit rDLDDIR4aeac0ea7845: Use the in-mem storage. (authored by vlorentz). · Explain WhyDec 5 2018, 2:18 PM
This revision was automatically updated to reflect the committed changes.
ardumont added inline comments.Dec 5 2018, 4:39 PM
swh/loader/dir/tests/test_loader.py
55

In my mind, if you don't define it, it's called anyway, isn't it?

anlambert added a subscriber: anlambert.Dec 5 2018, 4:41 PM
anlambert added inline comments.
swh/loader/dir/tests/test_loader.py
55

Yes it is ;-)

ardumont added inline comments.Dec 5 2018, 4:46 PM
swh/loader/dir/tests/test_loader.py
55

so it's not needed?!

;)

anlambert added inline comments.Dec 5 2018, 4:47 PM
swh/loader/dir/tests/test_loader.py
55

Absolutely not needed!

vlorentz marked an inline comment as done.Dec 5 2018, 5:29 PM
vlorentz added inline comments.
swh/loader/dir/tests/test_loader.py
55

But setUp needs to be defined, because it does other stuff (look just below this comment, that's still the setUp code)

anlambert added inline comments.Dec 5 2018, 5:32 PM
swh/loader/dir/tests/test_loader.py
55

Sorry, got mistaken by the comment boxes from Phabricator that was hiding the rest of the code and thought the method was only one line long.
So the call to the parent method is of course needed in that case.

ardumont added inline comments.Dec 5 2018, 5:38 PM
swh/loader/dir/tests/test_loader.py
55

Right, same here!

Revision Contents
Changeset List

PathSize
swh/
loader/
dir/
tests/
41 lines

Diff 2449

View Options

swh/loader/dir/tests/test_loader.py

Loading...
About · Developer information · Legal