I don't know any instance of these, but there is no harm in checking them.
Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Commits
- rDMOD8d96dfedee34: model: Validate Directory entry names
Diff Detail
Diff Detail
- Repository
- rDMOD Data model
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 25287 Build 39525: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 39524: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D6720 (id=24410)
Rebasing onto 2ffe5dba84...
Current branch diff-target is up to date.
Changes applied before test
commit 8d96dfedee34203a4118e48a6208ee507511590b
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Wed Dec 1 18:20:47 2021 +0100
model: Validate Directory entry names
I don't know any instance of these, but there is no harm in checking them.See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/403/ for more details.
Comment Actions
lgtm
... there is no harm in checking them
besides being slower you mean ;)
| swh/model/tests/test_model.py | ||
|---|---|---|
| 753 | I have no idea whether this is this true for all filesystems. | |
| swh/model/tests/test_model.py | ||
|---|---|---|
| 753 | what is? | |
| swh/model/tests/test_model.py | ||
|---|---|---|
| 753 | what you are tested here, the entries with the same name foo as file and dir. | |
| swh/model/tests/test_model.py | ||
|---|---|---|
| 753 | Ah, maybe. Anyway, this isn't tested at all in SWH, and the Cassandra schema doesn't support it. | |