Page MenuHomeSoftware Heritage

model: Validate Directory entry names
ClosedPublic

Authored by vlorentz on Dec 1 2021, 6:20 PM.

Details

Summary

I don't know any instance of these, but there is no harm in checking them.

Diff Detail

Repository
rDMOD Data model
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D6720 (id=24410)

Rebasing onto 2ffe5dba84...

Current branch diff-target is up to date.
Changes applied before test
commit 8d96dfedee34203a4118e48a6208ee507511590b
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Dec 1 18:20:47 2021 +0100

    model: Validate Directory entry names
    
    I don't know any instance of these, but there is no harm in checking them.

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/403/ for more details.

ardumont added a subscriber: ardumont.

lgtm

... there is no harm in checking them

besides being slower you mean ;)

swh/model/tests/test_model.py
752

I have no idea whether this is this true for all filesystems.

This revision is now accepted and ready to land.Dec 2 2021, 9:48 AM
swh/model/tests/test_model.py
752

what is?

swh/model/tests/test_model.py
752

what you are tested here, the entries with the same name foo as file and dir.

swh/model/tests/test_model.py
752

Ah, maybe. Anyway, this isn't tested at all in SWH, and the Cassandra schema doesn't support it.

This revision was automatically updated to reflect the committed changes.