pytest_plugin: Increase poll timeout in consume_messages
ClosedPublic
Actions

Authored by anlambert on Nov 17 2021, 4:36 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Commits

rDJNLbac6b474b229: pytest_plugin: Increase poll timeout in consume_messages

Summary

This prevents flaky test_storage_replayer in swh-storage tests.

The test above often fails when running the swh-environment Jenkins job.

I managed to reproduce the issue locally by running that test again and again in an infinite loop.

Once the poll timeout increased running the test again in an infinte loop does not fail anymore.

Diff Detail

Repository

rDJNL Journal infrastructure

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 25062
Build 39164: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 39163: arc lint + arc unit

Event Timeline

anlambert created this revision.Nov 17 2021, 4:36 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 17 2021, 4:36 PM

Build is green

Patch application report for D6649 (id=24175)

Rebasing onto a38c6e7e94...

First, rewinding head to replay your work on top of it...
Applying: pytest_plugin: Increase poll timeout in consume_messages

Changes applied before test

commit 6036945bc4d0bbc5606220e3d8b75f2397fdf380
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Nov 17 16:29:42 2021 +0100

    pytest_plugin: Increase poll timeout in consume_messages
    
    This prevents flaky test_storage_replayer in swh-storage tests.

See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/184/ for more details.

Harbormaster completed remote builds in B25056: Diff 24175.Nov 17 2021, 4:40 PM

anlambert requested review of this revision.Nov 17 2021, 4:40 PM

olasd accepted this revision.Nov 18 2021, 10:22 AM

This revision is now accepted and ready to land.Nov 18 2021, 10:22 AM

Rebase

Build is green

Patch application report for D6649 (id=24182)

Rebasing onto a38c6e7e94...

Current branch diff-target is up to date.

Changes applied before test

commit bac6b474b229e4c81edc4a3c6579a390b9767847
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Nov 17 16:29:42 2021 +0100

    pytest_plugin: Increase poll timeout in consume_messages
    
    This prevents flaky test_storage_replayer in swh-storage tests.

See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/185/ for more details.

Harbormaster completed remote builds in B25062: Diff 24182.Nov 18 2021, 10:32 AM

Closed by commit rDJNLbac6b474b229: pytest_plugin: Increase poll timeout in consume_messages (authored by anlambert). · Explain WhyNov 18 2021, 10:32 AM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDJNLbac6b474b229: pytest_plugin: Increase poll timeout in consume_messages.