Differential D6563
grab_next_visits: avoid time interval calculations in PostgreSQL Authored by olasd on Oct 27 2021, 3:49 PM.
Details
When the database is in a non-UTC timezone with DST, and a `timestamptz
calculation can be one hour off from the expected value: PostgreSQL will vary the timestamp by the amount of days in the Doing the datetime +- timedelta calculations in Python instead of tox passes when the database is in Europe/Paris timezone
Diff Detail
Event TimelineComment Actions Build is green Patch application report for D6563 (id=23848)Rebasing onto ecc0e2803e... Current branch diff-target is up to date. Changes applied before testcommit 0c7ef27b7e0542d2795a9720ebb5af2a3b274e18
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date: Wed Oct 27 15:45:09 2021 +0200
grab_next_visits: avoid time interval calculations in PostgreSQL
When the database is in a non-UTC timezone with DST, and a `timestamptz
- interval` calculation crosses a DST change, the result of the
calculation can be one hour off from the expected value:
PostgreSQL will vary the timestamp by the amount of days in the
interval, and will keep the same (local) time, which will be offset by
an hour because of the DST change.
Doing the datetime +- timedelta calculations in Python instead of
PostgreSQL avoids this caveat altogether.See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/482/ for more details. |