assets/save: Fix sourceforge git repository URL validation
ClosedPublic
Actions

Authored by anlambert on Oct 26 2021, 11:30 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T3690: Save code now ui rejects valid git sourceforge origin

Commits

rDWAPPS2f5d8cc1fbd3: assets/save: Fix sourceforge git repository URL validation

Summary

The assumption that URL paths to git repos for the git.code.sf.net
netloc are necessarily prefixed by /p/ is wrong.

Related to T3690

Diff Detail

Repository

rDWAPPS Web applications

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 24693
Build 38539: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 38538: arc lint + arc unit

Event Timeline

anlambert created this revision.Oct 26 2021, 11:30 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 26 2021, 11:30 AM

anlambert added a child revision: D6552: assets/save: Simplify origin URLs validation code.Oct 26 2021, 11:41 AM

Build is green

Patch application report for D6551 (id=23810)

Rebasing onto eb1d40198a...

Current branch diff-target is up to date.

Changes applied before test

commit 2f5d8cc1fbd3cb05825e37811c1951b5b6c24c77
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Oct 26 11:28:28 2021 +0200

    assets/save: Fix sourceforge git repository URL validation
    
    The assumption that URL paths to git repos for the git.code.sf.net
    netloc are necessarily prefixed by /p/ is wrong.
    
    Related to T3690

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1211/ for more details.

Harbormaster completed remote builds in B24693: Diff 23810.Oct 26 2021, 11:45 AM

anlambert requested review of this revision.Oct 26 2021, 11:45 AM

ardumont accepted this revision.Oct 26 2021, 12:16 PM

This revision is now accepted and ready to land.Oct 26 2021, 12:16 PM

Closed by commit rDWAPPS2f5d8cc1fbd3: assets/save: Fix sourceforge git repository URL validation (authored by anlambert). · Explain WhyOct 26 2021, 1:19 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS2f5d8cc1fbd3: assets/save: Fix sourceforge git repository URL validation.