Page MenuHomeSoftware Heritage

scheduler: Deprecate unused main celery runner
ClosedPublic

Authored by ardumont on Oct 20 2021, 9:39 AM.

Details

Summary

In future release, we'll be able to drop it.

Test Plan

tox

Diff Detail

Repository
rDSCH Scheduling utilities
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24540
Build 38291: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 38290: arc lint + arc unit

Event Timeline

Build has FAILED

Patch application report for D6512 (id=23644)

Rebasing onto 3aed6887fc...

Current branch diff-target is up to date.
Changes applied before test
commit 2a0437421879e44a8ec33b2b517c5bac5b238155
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Oct 20 09:36:27 2021 +0200

    scheduler: Deprecate unused main celery runner

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/456/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/456/console

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 20 2021, 9:44 AM
Harbormaster failed remote builds in B24535: Diff 23644!

Fix build, it wants the types-deprecated dependency

Build is green

Patch application report for D6512 (id=23647)

Rebasing onto 3aed6887fc...

Current branch diff-target is up to date.
Changes applied before test
commit bce856abdfc0462444de720588423b12683b0c05
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Oct 20 09:36:27 2021 +0200

    scheduler: Deprecate unused main celery runner

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/457/ for more details.

vlorentz added a subscriber: vlorentz.

Shouldn't the version be 0.18.3?

swh/scheduler/celery_backend/runner.py
154

Don't you mean this?

This revision is now accepted and ready to land.Oct 20 2021, 10:17 AM
swh/scheduler/celery_backend/runner.py
154

yes, well i meant, please check the --help output.
But if that's enough without it, fine ;)

Build is green

Patch application report for D6512 (id=23649)

Rebasing onto 3aed6887fc...

Current branch diff-target is up to date.
Changes applied before test
commit f15c51091439f499c5ab1c2cb75e3d058cb64341
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Oct 20 09:36:27 2021 +0200

    scheduler: Deprecate unused main celery runner

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/458/ for more details.