Differential D6453

converters: Prevent zero dates from being converted to null dates.
ClosedPublic
Actions

Authored by vlorentz on Oct 11 2021, 2:17 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDLDG0e824769ef86: converters: Prevent zero dates from being converted to null dates.

Summary

They are not serialized the same way, so they cause hash mismatches.

Addresses one of the issues in T75 + fixes Sentry issue SWH-LOADER-GIT-QC

Diff Detail

Repository

rDLDG Git loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Oct 11 2021, 2:17 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 11 2021, 2:17 PM

Build is green

Patch application report for D6453 (id=23437)

Rebasing onto d3d6042142...

Current branch diff-target is up to date.

Changes applied before test

commit 0e824769ef86cd83d8aa60127379819479356656
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Oct 11 14:16:19 2021 +0200

    converters: Prevent zero dates from being converted to null dates.
    
    They are not serialized the same way, so they cause hash mismatches.

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/143/ for more details.

Harbormaster completed remote builds in B24353: Diff 23437.Oct 11 2021, 2:21 PM

vlorentz requested review of this revision.Oct 11 2021, 2:21 PM