Page MenuHomeSoftware Heritage

converters: Prevent zero dates from being converted to null dates.
ClosedPublic

Authored by vlorentz on Mon, Oct 11, 2:17 PM.

Details

Summary

They are not serialized the same way, so they cause hash mismatches.

Addresses one of the issues in T75 + fixes Sentry issue SWH-LOADER-GIT-QC

Diff Detail

Repository
rDLDG Git loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D6453 (id=23437)

Rebasing onto d3d6042142...

Current branch diff-target is up to date.
Changes applied before test
commit 0e824769ef86cd83d8aa60127379819479356656
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Oct 11 14:16:19 2021 +0200

    converters: Prevent zero dates from being converted to null dates.
    
    They are not serialized the same way, so they cause hash mismatches.

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/143/ for more details.

anlambert added a subscriber: anlambert.

Looks good to me.

This revision is now accepted and ready to land.Mon, Oct 11, 2:26 PM