Differential D6300

Capture missing revision <-> hgnode-id scenario in a xfail test
ClosedPublic
Actions

Authored by ardumont on Sep 17 2021, 5:24 PM.

Details

Reviewers

douardda

Group Reviewers

Reviewers

Maniphest Tasks

T3584: loader mercurial edge case about missing mapping from revision to hgnode-id

Commits

rDLDHGef502bcdf3a2: Capture missing revision <-> hgnode-id scenario in a xfail test

Summary

anomad-d is the user-repository name. It's a repository which presents an anomaly in
some way. That anomaly makes the ingestion fail. I don't know what that anomaly is just
yet. It's something that's happening currently once in a while with the bitbucket
ingestion. It's just some work i did to prepare and analyze the problem either if i have
time to or if someone else wants to. That test if uncommented just fails. So that should
fairly help in debugging the problem.

(updated from my comment below)

Related to T3584

Test Plan

tox (happy)

To fix this, we need to uncomment the xfail and analyze ;)

Diff Detail

Repository

rDLDHG Mercurial loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 23827
Build 37153: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 37152: arc lint + arc unit

Event Timeline

ardumont created this revision.Sep 17 2021, 5:24 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 17 2021, 5:24 PM

Build is green

Patch application report for D6300 (id=22879)

Rebasing onto 8e3b880ebc...

Current branch diff-target is up to date.

Changes applied before test

commit b3965be02831dfcc434609b56b96458d92be9136
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 17 17:19:20 2021 +0200

    Capture missing revision <-> hgnode-id scenario in a xfail test
    
    Related to T3584

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/307/ for more details.

Harbormaster completed remote builds in B23807: Diff 22879.Sep 17 2021, 5:26 PM

ardumont requested review of this revision.Sep 17 2021, 5:26 PM

I don't understand what exactly is (not) tested here. What does "anomad-d" stand for BTW?

Why is this new dataset needed? What's in there? Where does it come from?

This revision now requires changes to proceed.Sep 20 2021, 9:59 AM

anomad-d is the user-repository name. It's a repository which presents an anomaly in some way. That anomaly makes the ingestion fail.

I don't know that anomaly is just yet. It's something that's happening currently once in a while with the bitbucket ingestion.

It's just some work i did to prepare and analyze the problem either if i have time to or if someone else wants to.

That test if uncommented just fails. So that should fairly help in debugging the problem.

ardumont edited the summary of this revision. (Show Details)Sep 20 2021, 12:23 PM

ardumont edited the test plan for this revision. (Show Details)

vlorentz added a subscriber: vlorentz.Sep 20 2021, 1:48 PM

vlorentz added inline comments.

swh/loader/mercurial/tests/test_from_disk.py
729	should change this docstring

italic text

swh/loader/mercurial/tests/test_from_disk.py
729	right. I should even drop it as i don't know what the current problem actually is.

ardumont edited the summary of this revision. (Show Details)Sep 20 2021, 2:28 PM

Adapt test docstring into a todo since it's actually a todo

ardumont marked an inline comment as done.Sep 20 2021, 5:00 PM

Build is green

Patch application report for D6300 (id=22900)

Rebasing onto 8e3b880ebc...

Current branch diff-target is up to date.

Changes applied before test

commit 46afc6a5ffe8f0abac51a0478ad2078f906500d3
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 17 17:19:20 2021 +0200

    Capture missing revision <-> hgnode-id scenario in a xfail test
    
    Related to T3584

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/308/ for more details.

Harbormaster completed remote builds in B23827: Diff 22900.Sep 20 2021, 5:02 PM

Update commit message with the diff explanation

Build is green

Patch application report for D6300 (id=22921)

Rebasing onto 8e3b880ebc...

Current branch diff-target is up to date.

Changes applied before test

commit ef502bcdf3a2717a5d582db6c3658ae4788def7c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 17 17:19:20 2021 +0200

    Capture missing revision <-> hgnode-id scenario in a xfail test
    
    anomad-d is the `user`-`repository` name.
    
    It's a repository which presents an anomaly in some undefined way yet. That anomaly
    makes the ingestion fail.
    
    It's something that's happening currently once in a while with the bitbucket ingestion.
    This commit is just a preparatory work to analyze the problem either if i have time to
    or if someone else wants to.
    
    To analyze comment the xfail mark and let the test fail, then debug. That should fairly
    help.
    
    Related to T3584

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/309/ for more details.

Harbormaster completed remote builds in B23850: Diff 22921.Sep 21 2021, 11:16 AM

douardda accepted this revision.Sep 22 2021, 10:37 AM

This revision is now accepted and ready to land.Sep 22 2021, 10:37 AM

ardumont mentioned this in D6329: Fix branch bookmark id format so ingestion can finish.Sep 23 2021, 10:14 AM

ardumont added a child revision: D6329: Fix branch bookmark id format so ingestion can finish.Sep 23 2021, 10:14 AM

Landed through ef502bc

ardumont closed this revision.Sep 23 2021, 10:56 AM

ardumont added a commit: rDLDHGef502bcdf3a2: Capture missing revision <-> hgnode-id scenario in a xfail test.Jul 3 2022, 2:09 PM