Differential D6298

eliminate code duplication of logic in process_cvs_changesets()
ClosedPublic
Actions

Authored by stsp on Sep 17 2021, 4:43 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDLDCVSa7eaeb89f46f: eliminate code duplication of logic in process_cvs_changesets()

Summary

Factor out code which is specific to rcsparse and cvsclient into
separate functions and pass a parameter to process_cvs_changesets()
so it can decide which of the two needs to be used.

This supersedes the function process_cvs_rlog_changesets() which
duplicated the looping code also contained in process_cvs_changesets().

Diff Detail

Repository

rDLDCVS CVS Loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 23816
Build 37136: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 37135: arc lint + arc unit

Event Timeline

stsp created this revision.Sep 17 2021, 4:43 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 17 2021, 4:43 PM

Build has FAILED

Patch application report for D6298 (id=22875)

Rebasing onto dd8a625ca0...

Current branch diff-target is up to date.

Changes applied before test

commit b982fa244c2da87a0b1140be48a0f932cb494af1
Author: Stefan Sperling <stsp@stsp.name>
Date:   Fri Sep 17 16:39:58 2021 +0200

    eliminate code duplication of logic in process_cvs_changesets()
    
    Factor out code which is specific to rcsparse and cvsclient into
    separate functions and pass a parameter to process_cvs_changesets()
    so it can decide which of the two needs to be used.
    
    This supersedes the function process_cvs_rlog_changesets() which
    duplicated the looping code also contained in process_cvs_changesets().

Link to build: https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/19/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/19/console

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 17 2021, 4:44 PM

Harbormaster failed remote builds in B23804: Diff 22875!

apply reformatting by black

Build is green

Patch application report for D6298 (id=22888)

Rebasing onto dd8a625ca0...

Current branch diff-target is up to date.

Changes applied before test

commit 6ff2c133f98183c443d0fa774cb83a539229094c
Author: Stefan Sperling <stsp@stsp.name>
Date:   Fri Sep 17 16:39:58 2021 +0200

    eliminate code duplication of logic in process_cvs_changesets()
    
    Factor out code which is specific to rcsparse and cvsclient into
    separate functions and pass a parameter to process_cvs_changesets()
    so it can decide which of the two needs to be used.
    
    This supersedes the function process_cvs_rlog_changesets() which
    duplicated the looping code also contained in process_cvs_changesets().

See https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/21/ for more details.

Harbormaster completed remote builds in B23816: Diff 22888.Sep 17 2021, 6:19 PM

stsp requested review of this revision.Sep 17 2021, 6:19 PM

vlorentz accepted this revision.Sep 17 2021, 6:20 PM

This revision is now accepted and ready to land.Sep 17 2021, 6:20 PM

rebased patch

Build is green

Patch application report for D6298 (id=22956)

Rebasing onto a6e9882352...

Current branch diff-target is up to date.

Changes applied before test

commit a7eaeb89f46f7e027e60d2f0acdcb7453f1a2431
Author: Stefan Sperling <stsp@stsp.name>
Date:   Fri Sep 17 16:39:58 2021 +0200

    eliminate code duplication of logic in process_cvs_changesets()
    
    Factor out code which is specific to rcsparse and cvsclient into
    separate functions and pass a parameter to process_cvs_changesets()
    so it can decide which of the two needs to be used.
    
    This supersedes the function process_cvs_rlog_changesets() which
    duplicated the looping code also contained in process_cvs_changesets().

See https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/27/ for more details.

Harbormaster completed remote builds in B23887: Diff 22956.Sep 22 2021, 12:18 PM

Closed by commit rDLDCVSa7eaeb89f46f: eliminate code duplication of logic in process_cvs_changesets() (authored by stsp). · Explain WhySep 22 2021, 12:29 PM

This revision was automatically updated to reflect the committed changes.

stsp added a commit: rDLDCVSa7eaeb89f46f: eliminate code duplication of logic in process_cvs_changesets().