eg. self.log.exception already include the exception (and its traceback),
so it does not need to be part of the message.
Depends on D6293.
Details
Details
Diff Detail
Diff Detail
- Repository
- rDLDCVS CVS Loader
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 23801 Build 37108: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 37107: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D6295 (id=22872)
Could not rebase; Attempt merge onto dd8a625ca0...
Auto-merging swh/loader/cvs/loader.py Merge made by the 'recursive' strategy. swh/loader/cvs/loader.py | 65 ++++++++++++++++++++----------------- swh/loader/cvs/tests/test_loader.py | 3 ++ 2 files changed, 39 insertions(+), 29 deletions(-)
Changes applied before test
commit c32f4c26371ba11ae2a8d4370f48013e740e5551
Merge: dd8a625 af37557
Author: Jenkins user <jenkins@localhost>
Date: Fri Sep 17 14:35:14 2021 +0000
Merge branch 'diff-target' into HEAD
commit af3755766012b58ddf5713fb2e0504033c9de903
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Fri Sep 17 16:34:37 2021 +0200
Use lazy substitution for logging + fix error messages
eg. self.log.exception already include the exception (and its traceback),
so it does not need to be part of the message.
commit b7e97029636648ddb53ad7bed8623e97a546e445
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Fri Sep 17 16:28:52 2021 +0200
load_status should not be 'uneventful' if the snapshot changed
Even if the revision was already loaded; it might have been for
a different origin.See https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/16/ for more details.
Comment Actions
Build is green
Patch application report for D6295 (id=22938)
Could not rebase; Attempt merge onto dd8a625ca0...
Updating dd8a625..6d6c456 Fast-forward swh/loader/cvs/loader.py | 65 ++++++++++++++++++++----------------- swh/loader/cvs/tests/test_loader.py | 3 ++ 2 files changed, 39 insertions(+), 29 deletions(-)
Changes applied before test
commit 6d6c456b487b2e671867fafa8ed34a5cbb604176
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Fri Sep 17 16:34:37 2021 +0200
Use lazy substitution for logging + fix error messages
eg. self.log.exception already include the exception (and its traceback),
so it does not need to be part of the message.
commit b8ceb52f45493354425d73f28198b58444a2ccbb
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Fri Sep 17 16:28:52 2021 +0200
load_status should not be 'uneventful' if the snapshot changed
Even if the revision was already loaded; it might have been for
a different origin.See https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/23/ for more details.