Differential D6292

Ensure that filename fallback out of an url is properly sanitized
ClosedPublic
Actions

Authored by ardumont on Sep 17 2021, 4:10 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Maniphest Tasks

T3468: staging: current opam loading issues

Commits

rDLDBASEfabd950d3657: Ensure that filename fallback out of an url is properly sanitized

Summary

Otherwise, filename may end up being too long [1]

OSError: [Errno 36] File name too long:

Related to T3468

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Sep 17 2021, 4:10 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 17 2021, 4:10 PM

Build is green

Patch application report for D6292 (id=22867)

Rebasing onto f4fe1f30bb...

Current branch diff-target is up to date.

Changes applied before test

commit fabd950d36575aeefd1ec4213c19dc89a4443107
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 17 16:09:07 2021 +0200

    Ensure that filename fallback out of an url is properly sanitized
    
    Otherwise, filename may end up being too long [1]

OSError: [Errno 36] File name too long:
```

Related to T3468

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/559/ for more details.

Harbormaster completed remote builds in B23796: Diff 22867.Sep 17 2021, 4:12 PM

ardumont requested review of this revision.Sep 17 2021, 4:12 PM

Looks good to me, thanks !

This revision is now accepted and ready to land.Sep 17 2021, 4:15 PM

Closed by commit rDLDBASEfabd950d3657: Ensure that filename fallback out of an url is properly sanitized (authored by ardumont). · Explain WhySep 17 2021, 4:16 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDBASEfabd950d3657: Ensure that filename fallback out of an url is properly sanitized.

Revision Contents
Changeset List

Path

Size

swh/

loader/

package/

tests/

test_utils.py

11 lines

utils.py

5 lines

Diff 22868

View Options

swh/loader/package/tests/test_utils.py