Differential D6216

utils: Fix unescape() on non-ASCII strings.
ClosedPublic
Actions

Authored by vlorentz on Sep 8 2021, 5:09 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDSEA7f1f1be3f253: utils: Fix unescape() on non-ASCII strings.

Summary

'unicode_escape' assumes latin-1 as input.

Requirement to resolve SWH-SEARCH-12

Diff Detail

Repository

rDSEA Archive search

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 23445
Build 36585: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 36584: arc lint + arc unit

Event Timeline

vlorentz created this revision.Sep 8 2021, 5:09 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 8 2021, 5:09 PM

vlorentz edited the summary of this revision. (Show Details)Sep 8 2021, 5:12 PM

vlorentz added a child revision: D6217: translator: Fix parsing of multibyte characters.

Build is green

Patch application report for D6216 (id=22495)

Rebasing onto 7479282c70...

Current branch diff-target is up to date.

Changes applied before test

commit 7f1f1be3f253e9ed59807491eb1043616a0bf4e3
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Sep 8 17:08:46 2021 +0200

    utils: Fix unescape() on non-ASCII strings.
    
    'unicode_escape' assumes latin-1 as input.

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/291/ for more details.

Harbormaster completed remote builds in B23445: Diff 22495.Sep 8 2021, 5:13 PM

vlorentz requested review of this revision.Sep 8 2021, 5:13 PM

anlambert accepted this revision.Sep 9 2021, 11:31 AM

This revision is now accepted and ready to land.Sep 9 2021, 11:31 AM

Closed by commit rDSEA7f1f1be3f253: utils: Fix unescape() on non-ASCII strings. (authored by vlorentz). · Explain WhySep 9 2021, 11:50 AM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDSEA7f1f1be3f253: utils: Fix unescape() on non-ASCII strings..

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

swh/

search/

utils.py

11 lines

96%

Diff 22495

View Options

utils: Fix unescape() on non-ASCII strings.ClosedPublicActions