Page MenuHomeSoftware Heritage

utils: Fix unescape() on non-ASCII strings.
ClosedPublic

Authored by vlorentz on Sep 8 2021, 5:09 PM.

Details

Summary

'unicode_escape' assumes latin-1 as input.

Requirement to resolve SWH-SEARCH-12

Diff Detail

Repository
rDSEA Archive search
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23445
Build 36585: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 36584: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D6216 (id=22495)

Rebasing onto 7479282c70...

Current branch diff-target is up to date.
Changes applied before test
commit 7f1f1be3f253e9ed59807491eb1043616a0bf4e3
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Sep 8 17:08:46 2021 +0200

    utils: Fix unescape() on non-ASCII strings.
    
    'unicode_escape' assumes latin-1 as input.

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/291/ for more details.

This revision is now accepted and ready to land.Sep 9 2021, 11:31 AM