Reword 'no more available to download' in more natural English
ClosedPublic
Actions

Authored by vlorentz on Aug 27 2021, 10:00 AM.

Details

Reviewers

anlambert
ardumont

Group Reviewers

Reviewers

Commits

rDWAPPSe9f7a91bc390: Reword 'no more available to download' in more natural English

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Aug 27 2021, 10:00 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 27 2021, 10:00 AM

Build is green

Patch application report for D6148 (id=22251)

Rebasing onto 66865c37ce...

Current branch diff-target is up to date.

Changes applied before test

commit 68e5608fa4b1f413f8c7f5d56896f242dda7e8c2
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Aug 27 10:00:09 2021 +0200

    Reword 'no more available to download' in more natural English

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1037/ for more details.

Harbormaster completed remote builds in B23210: Diff 22251.Aug 27 2021, 10:13 AM

vlorentz requested review of this revision.Aug 27 2021, 10:13 AM

ardumont added a subscriber: ardumont.Aug 27 2021, 10:32 AM

ardumont added inline comments.

cypress/integration/vault.spec.js
402	This one sounds better to me ^ what do you think?
swh/web/templates/includes/vault-common.html
20

vlorentz added inline comments.Aug 27 2021, 10:41 AM

cypress/integration/vault.spec.js
402	equivalent imo
swh/web/templates/includes/vault-common.html
20	"no longer" and "anymore" are redundant

anlambert accepted this revision.Aug 27 2021, 10:45 AM

This revision is now accepted and ready to land.Aug 27 2021, 10:45 AM

apply comments

Build is green

Patch application report for D6148 (id=22272)

Rebasing onto 66865c37ce...

Current branch diff-target is up to date.

Changes applied before test

commit e9f7a91bc390869f3f62e98361701ec911c15515
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Aug 27 10:00:09 2021 +0200

    Reword 'no more available to download' in more natural English

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1038/ for more details.

Harbormaster completed remote builds in B23229: Diff 22272.Aug 27 2021, 2:16 PM

ardumont accepted this revision.Aug 27 2021, 2:29 PM

Closed by commit rDWAPPSe9f7a91bc390: Reword 'no more available to download' in more natural English (authored by vlorentz). · Explain WhyAug 27 2021, 2:30 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDWAPPSe9f7a91bc390: Reword 'no more available to download' in more natural English.