Differential D6125

vault.spec.js: Remove vaultItems from global variables
ClosedPublic
Actions

Authored by vlorentz on Aug 24 2021, 11:23 AM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDWAPPS7dde85502888: vault.spec.js: Remove vaultItems from global variables

Summary

So tests don't have side-effects

Diff Detail

Repository

rDWAPPS Web applications

Branch

prepare-vault

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 23112
Build 36046: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 36045: arc lint + arc unit

Event Timeline

vlorentz created this revision.Aug 24 2021, 11:23 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 24 2021, 11:23 AM

vlorentz added a child revision: D6126: vault.spec.js: Add test checking the LocalStorage is used to show the task list.Aug 24 2021, 11:24 AM

Build is green

Patch application report for D6125 (id=22155)

Rebasing onto 8acd726369...

First, rewinding head to replay your work on top of it...
Applying: vault.spec.js: Remove vaultItems from global variables

Changes applied before test

commit cbaea882d109bf8419d71cdb9288cba9f4d6c860
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Aug 24 10:19:22 2021 +0200

    vault.spec.js: Remove vaultItems from global variables
    
    So tests don't have side-effects

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1018/ for more details.

Harbormaster completed remote builds in B23112: Diff 22155.Aug 24 2021, 11:37 AM

vlorentz requested review of this revision.Aug 24 2021, 11:37 AM

anlambert accepted this revision.Aug 24 2021, 1:49 PM

This revision is now accepted and ready to land.Aug 24 2021, 1:49 PM

7dde8550288892a23ea3128a52e4a67d3aad9802

vlorentz added a commit: rDWAPPS7dde85502888: vault.spec.js: Remove vaultItems from global variables.Aug 25 2021, 10:11 AM

Revision Contents
Changeset List

Path

Size

cypress/

integration/

vault.spec.js

28 lines

Diff 22155

View Options

cypress/integration/vault.spec.js

vault.spec.js: Remove vaultItems from global variablesClosedPublicActions