Add stream_results_optional
ClosedPublic
Actions

Authored by vlorentz on Jul 30 2021, 3:57 PM.

Details

Reviewers

douardda
ardumont

Group Reviewers

Reviewers

Commits

rDCORE3337e79642e0: Add stream_results_optional

Summary

It's needed to properly read from storage.directory_get_entries,
which returns None instead of empty iterators when a directory
is not found (so clients can tell the difference with the empty
directory without hardcoding its hash).

Diff Detail

Repository

rDCORE Foundations and core functionalities

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 22838
Build 35618: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 35617: arc lint + arc unit

Event Timeline

vlorentz created this revision.Jul 30 2021, 3:57 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 30 2021, 3:57 PM

vlorentz added a reviewer: douardda.Jul 30 2021, 3:57 PM

Build is green

Patch application report for D6047 (id=21873)

Rebasing onto 02bf96407f...

Current branch diff-target is up to date.

Changes applied before test

commit c01a6068f498fb7a1436e07149c3ce5d47c74ca5
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jul 30 15:57:20 2021 +0200

    Add stream_results_optional
    
    It's needed to properly read from storage.directory_get_entries,
    which returns None instead of empty iterators when a directory
    is not found (so clients can tell the difference with the empty
    directory without hardcoding its hash).

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/234/ for more details.

Harbormaster completed remote builds in B22836: Diff 21873.Jul 30 2021, 3:59 PM

vlorentz requested review of this revision.Jul 30 2021, 3:59 PM

ardumont added a subscriber: ardumont.Jul 30 2021, 4:02 PM

ardumont added inline comments.

swh/core/api/classes.py
49	should be simple enough to add both missing conditional test in there. Can you please do it at the same time?

looks sound to me, i'd add the 2 missing tests (which ensure we don't call stream_result* with page_token) since we are touching that part.

add test_stream_results_kwarg

Build is green

Patch application report for D6047 (id=21874)

Rebasing onto 02bf96407f...

Current branch diff-target is up to date.

Changes applied before test

commit 1182e126a53a03e72d34f3135ed1b0211a3bbf75
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jul 30 15:57:20 2021 +0200

    Add stream_results_optional
    
    It's needed to properly read from storage.directory_get_entries,
    which returns None instead of empty iterators when a directory
    is not found (so clients can tell the difference with the empty
    directory without hardcoding its hash).

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/235/ for more details.

Harbormaster completed remote builds in B22837: Diff 21874.Jul 30 2021, 4:11 PM

oops I didn't mean to commit this yet

vlorentz marked an inline comment as done.Jul 30 2021, 4:12 PM

Build is green

Patch application report for D6047 (id=21875)

Rebasing onto 02bf96407f...

Current branch diff-target is up to date.

Changes applied before test

commit 3337e79642e01f28abff732fa91a3a8c2faf6e6a
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jul 30 15:57:20 2021 +0200

    Add stream_results_optional
    
    It's needed to properly read from storage.directory_get_entries,
    which returns None instead of empty iterators when a directory
    is not found (so clients can tell the difference with the empty
    directory without hardcoding its hash).

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/236/ for more details.

Harbormaster completed remote builds in B22838: Diff 21875.Jul 30 2021, 4:13 PM

ardumont accepted this revision.Jul 30 2021, 4:41 PM

This revision is now accepted and ready to land.Jul 30 2021, 4:41 PM

Closed by commit rDCORE3337e79642e0: Add stream_results_optional (authored by vlorentz). · Explain WhyJul 30 2021, 4:44 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDCORE3337e79642e0: Add stream_results_optional.