Page MenuHomeSoftware Heritage
Differential D6000

git_bare: Add support for annotated tags pointing to commits
ClosedPublic
Actions

Authored by vlorentz on Jul 16 2021, 2:26 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Maniphest Tasks
T843: Vault: Add a "git bare" tarball cooker
Commits
rDVAU73b2b13b9e06: git_bare: Add support for annotated tags pointing to commits
Summary

Depends on D5999.

Diff Detail

Event Timeline

vlorentz created this revision.Jul 16 2021, 2:26 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJul 16 2021, 2:26 PM
vlorentz updated this revision to Diff 21660.Jul 16 2021, 2:27 PM

remove comment that shouldn't be committed yet

swh-public-ci added a comment.Jul 16 2021, 2:28 PM

Build has FAILED

Patch application report for D6000 (id=21659)

Could not rebase; Attempt merge onto 5951a5c63b...

Updating 5951a5c..6629eda
Fast-forward
 swh/vault/cookers/__init__.py   |   1 +
 swh/vault/cookers/git_bare.py   |  97 ++++++++++-
 swh/vault/tests/test_cookers.py | 378 ++++++++++++++++++++++++++++++++++------
 3 files changed, 416 insertions(+), 60 deletions(-)
Changes applied before test
commit 6629edaf1e5d5c8c4dc3ca8e668d768373077e84
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jul 16 14:25:35 2021 +0200

    git_bare: Add support for annotated tags pointing to commits

commit 4cb80723d8fbd094bd5b6439d71cfc2e2e091a86
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jul 15 19:46:54 2021 +0200

    git_bare: Add partial support for snapshots (no release or swh-graph support yet)

commit 70fc50f40b8bc13b022f96be0027e89175773fd7
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jul 15 17:20:44 2021 +0200

    tests: Split RepoFixtures off TestRevisionCooker
    
    So the 'load' and 'check' parts of the tests can be reused by future
    snapshot tests.

commit a1f42284c683ec1d0ee169cda67f507529822473
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jul 15 16:58:55 2021 +0200

    tests: Make TestRevisionCooker more modular
    
    So its 'load' and 'check' parts can be reused for testing snapshots

Link to build: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/136/
See console output for more information: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/136/console

Harbormaster failed remote builds in B22629: Diff 21659!Jul 16 2021, 2:28 PM
swh-public-ci added a comment.Jul 16 2021, 2:30 PM

Build has FAILED

Patch application report for D6000 (id=21660)

Rebasing onto 5951a5c63b...

Current branch diff-target is up to date.
Changes applied before test
commit c427dd8017062e37dfe0bfdd3113cd0999e30d55
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jul 16 14:25:35 2021 +0200

    git_bare: Add support for annotated tags pointing to commits

commit 4cb80723d8fbd094bd5b6439d71cfc2e2e091a86
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jul 15 19:46:54 2021 +0200

    git_bare: Add partial support for snapshots (no release or swh-graph support yet)

commit 70fc50f40b8bc13b022f96be0027e89175773fd7
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jul 15 17:20:44 2021 +0200

    tests: Split RepoFixtures off TestRevisionCooker
    
    So the 'load' and 'check' parts of the tests can be reused by future
    snapshot tests.

commit a1f42284c683ec1d0ee169cda67f507529822473
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jul 15 16:58:55 2021 +0200

    tests: Make TestRevisionCooker more modular
    
    So its 'load' and 'check' parts can be reused for testing snapshots

Link to build: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/137/
See console output for more information: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/137/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 16 2021, 2:30 PM
Harbormaster failed remote builds in B22630: Diff 21660!
vlorentz updated this revision to Diff 21662.Jul 16 2021, 2:30 PM

change base commit

swh-public-ci added a comment.Jul 16 2021, 2:34 PM

Build has FAILED

Patch application report for D6000 (id=21662)

Could not rebase; Attempt merge onto 5951a5c63b...

Updating 5951a5c..c427dd8
Fast-forward
 swh/vault/cookers/__init__.py   |   1 +
 swh/vault/cookers/git_bare.py   |  94 +++++++++-
 swh/vault/tests/test_cookers.py | 378 ++++++++++++++++++++++++++++++++++------
 3 files changed, 413 insertions(+), 60 deletions(-)
Changes applied before test
commit c427dd8017062e37dfe0bfdd3113cd0999e30d55
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jul 16 14:25:35 2021 +0200

    git_bare: Add support for annotated tags pointing to commits

commit 4cb80723d8fbd094bd5b6439d71cfc2e2e091a86
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jul 15 19:46:54 2021 +0200

    git_bare: Add partial support for snapshots (no release or swh-graph support yet)

commit 70fc50f40b8bc13b022f96be0027e89175773fd7
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jul 15 17:20:44 2021 +0200

    tests: Split RepoFixtures off TestRevisionCooker
    
    So the 'load' and 'check' parts of the tests can be reused by future
    snapshot tests.

commit a1f42284c683ec1d0ee169cda67f507529822473
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jul 15 16:58:55 2021 +0200

    tests: Make TestRevisionCooker more modular
    
    So its 'load' and 'check' parts can be reused for testing snapshots

Link to build: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/139/
See console output for more information: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/139/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 16 2021, 2:34 PM
Harbormaster failed remote builds in B22632: Diff 21662!
vlorentz updated this revision to Diff 21663.Jul 16 2021, 2:48 PM

fix test on jenkins

swh-public-ci added a comment.Jul 16 2021, 2:50 PM

Build has FAILED

Patch application report for D6000 (id=21663)

Could not rebase; Attempt merge onto 5951a5c63b...

Updating 5951a5c..6c5f074
Fast-forward
 swh/vault/cookers/__init__.py   |   1 +
 swh/vault/cookers/git_bare.py   |  94 +++++++++-
 swh/vault/tests/test_cookers.py | 378 ++++++++++++++++++++++++++++++++++------
 3 files changed, 413 insertions(+), 60 deletions(-)
Changes applied before test
commit 6c5f0746228febc14b3445451f4645ae46409994
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jul 16 14:25:35 2021 +0200

    git_bare: Add support for annotated tags pointing to commits

commit 4cb80723d8fbd094bd5b6439d71cfc2e2e091a86
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jul 15 19:46:54 2021 +0200

    git_bare: Add partial support for snapshots (no release or swh-graph support yet)

commit 70fc50f40b8bc13b022f96be0027e89175773fd7
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jul 15 17:20:44 2021 +0200

    tests: Split RepoFixtures off TestRevisionCooker
    
    So the 'load' and 'check' parts of the tests can be reused by future
    snapshot tests.

commit a1f42284c683ec1d0ee169cda67f507529822473
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jul 15 16:58:55 2021 +0200

    tests: Make TestRevisionCooker more modular
    
    So its 'load' and 'check' parts can be reused for testing snapshots

Link to build: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/140/
See console output for more information: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/140/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 16 2021, 2:50 PM
Harbormaster failed remote builds in B22633: Diff 21663!
vlorentz updated this revision to Diff 21665.Jul 16 2021, 3:22 PM

really fix this time.

swh-public-ci added a comment.Jul 16 2021, 3:25 PM

Build is green

Patch application report for D6000 (id=21665)

Could not rebase; Attempt merge onto 5951a5c63b...

Updating 5951a5c..73b2b13
Fast-forward
 swh/vault/cookers/__init__.py   |   1 +
 swh/vault/cookers/git_bare.py   |  94 +++++++++-
 swh/vault/tests/test_cookers.py | 378 ++++++++++++++++++++++++++++++++++------
 3 files changed, 413 insertions(+), 60 deletions(-)
Changes applied before test
commit 73b2b13b9e06a8bdf5f6ea5d3b526d1e0c53fcf9
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jul 16 14:25:35 2021 +0200

    git_bare: Add support for annotated tags pointing to commits

commit 4cb80723d8fbd094bd5b6439d71cfc2e2e091a86
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jul 15 19:46:54 2021 +0200

    git_bare: Add partial support for snapshots (no release or swh-graph support yet)

commit 70fc50f40b8bc13b022f96be0027e89175773fd7
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jul 15 17:20:44 2021 +0200

    tests: Split RepoFixtures off TestRevisionCooker
    
    So the 'load' and 'check' parts of the tests can be reused by future
    snapshot tests.

commit a1f42284c683ec1d0ee169cda67f507529822473
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jul 15 16:58:55 2021 +0200

    tests: Make TestRevisionCooker more modular
    
    So its 'load' and 'check' parts can be reused for testing snapshots

See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/142/ for more details.

Harbormaster completed remote builds in B22635: Diff 21665.Jul 16 2021, 3:25 PM
vlorentz requested review of this revision.Jul 16 2021, 3:25 PM
vlorentz added a child revision: D6002: git_bare: Add support for swh-graph when loading a snapshot.Jul 19 2021, 10:48 AM
ardumont accepted this revision.Jul 19 2021, 2:27 PM
This revision is now accepted and ready to land.Jul 19 2021, 2:27 PM
Closed by commit rDVAU73b2b13b9e06: git_bare: Add support for annotated tags pointing to commits (authored by vlorentz). · Explain WhyJul 26 2021, 2:30 PM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDVAU73b2b13b9e06: git_bare: Add support for annotated tags pointing to commits.
vlorentz added a task: T843: Vault: Add a "git bare" tarball cooker.Aug 2 2021, 1:56 PM

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
vault/
cookers/
28 lines96%
Loading...
tests/
81 lines99%
Loading...

Diff 21665

View Options

swh/vault/cookers/git_bare.py

Loading...
View Options

swh/vault/tests/test_cookers.py

Loading...
About · Developer information · Legal