This ensures mypy will not produce errors while being able to run tests
regardless pytest-postgresql version (<3 or >=3).
This fixes current build of swh-core master branch.
Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Commits
- rDCORE94aa00b94c79: db/pytest_plugin: Keep mypy happy regardless pytest-postgresql version
Diff Detail
Diff Detail
- Repository
- rDCORE Foundations and core functionalities
- Branch
- pytest-postgresql-mypy-fixes
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 21809 Build 33914: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 33913: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D5827 (id=20847)
Rebasing onto c3c387ddd4...
Current branch diff-target is up to date.
Changes applied before test
commit 94aa00b94c797e7bf4b983871605610c8389dede
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date: Tue Jun 8 15:21:41 2021 +0200
db/pytest_plugin: Keep mypy happy regardless pytest-postgresql version
This ensures mypy will not produce errors while being able to run tests
regardless pytest-postgresql version (<3 or >=3).See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/226/ for more details.
| swh/core/db/pytest_plugin.py | ||
|---|---|---|
| 48 | Adding #type: ignore raises a mypy error when using pytest-postgresql<3 so I removed Version in the union instead, this has no impact on other modules using the postgresql_fact fixture factory. | |