We still don't have a use for them, and they are causing issues;
such as being unable to add an authority/fetcher based only
on a REMD object, which is needed by the replayer.
Resolves T3303.
Details
Details
- Reviewers
douardda - Group Reviewers
Reviewers - Maniphest Tasks
- T3303: Replaying REMD topics is broken
- Commits
- rDSTOe170fb29fde7: Stop storing authority/fetcher metadata.
Diff Detail
Diff Detail
- Repository
- rDSTO Storage manager
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 21250 Build 32996: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 32995: arc lint + arc unit
Event Timeline
Comment Actions
Build has FAILED
Patch application report for D5670 (id=20256)
Rebasing onto 051b771523...
Current branch diff-target is up to date.
Changes applied before test
commit e2afe93b756bd073ff855bfc45d0b1baa197f22e
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Tue May 4 16:04:38 2021 +0200
Stop storing authority/fetcher metadata.
We still don't have a use for them, and they are causing issues;
such as being unable to add an authority/fetcher based only
on a REMD object, which is needed by the replayer.Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1301/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1301/console
Comment Actions
maybe add a "fixer" also (in fixers.py) for the replayer to not break because of a metadata field in a kafka message?
Comment Actions
@douardda It won't break, because the metadata field will simply be ignored.
But I'll add a fixer in a future diff, so I can remove the field from the model.
Comment Actions
Build was aborted
Patch application report for D5670 (id=20263)
Rebasing onto 051b771523...
Current branch diff-target is up to date.
Changes applied before test
commit f9ca2fa32a122c8e839b7ef252a6b2813b971328
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Tue May 4 16:04:38 2021 +0200
Stop storing authority/fetcher metadata.
We still don't have a use for them, and they are causing issues;
such as being unable to add an authority/fetcher based only
on a REMD object, which is needed by the replayer.Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1303/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1303/console
Comment Actions
Build is green
Patch application report for D5670 (id=20263)
Rebasing onto 051b771523...
Current branch diff-target is up to date.
Changes applied before test
commit f9ca2fa32a122c8e839b7ef252a6b2813b971328
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Tue May 4 16:04:38 2021 +0200
Stop storing authority/fetcher metadata.
We still don't have a use for them, and they are causing issues;
such as being unable to add an authority/fetcher based only
on a REMD object, which is needed by the replayer.See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1304/ for more details.
Comment Actions
But I'll add a fixer in a future diff, so I can remove the field from the model.
Actually, that's not even needed because that field was not written to Kafka.
Comment Actions
Build is green
Patch application report for D5670 (id=20291)
Rebasing onto 77ef651d95...
Current branch diff-target is up to date.
Changes applied before test
commit e170fb29fde7ddc896b28f60505f64adf3631410
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Tue May 4 16:04:38 2021 +0200
Stop storing authority/fetcher metadata.
We still don't have a use for them, and they are causing issues;
such as being unable to add an authority/fetcher based only
on a REMD object, which is needed by the replayer.See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1308/ for more details.