identifiers: Add support for resolving core SWHID with uppercase chars
ClosedPublic
Actions

Authored by anlambert on Apr 29 2021, 5:41 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T3298: Consider making SWHID handling case insensitive

Commits

rDWAPPSfde7413968ad: identifiers: Add support for resolving core SWHID with uppercase chars

Summary

The following SWHIDs will now be resolved without error:

SWH:1:CNT:9BC077A025CBA4C5B3628B0EABB4D3AAC0F35C63

SWH:1:CNT:9BC077A025CBA4C5B3628B0EABB4D3AAC0F35C63;origin=https://github.com/git/git

Related to T3298

Diff Detail

Repository

rDWAPPS Web applications

Branch

resolve-uppercase-core-swhid

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 21157
Build 32836: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 32835: arc lint + arc unit

Event Timeline

anlambert created this revision.Apr 29 2021, 5:41 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 29 2021, 5:41 PM

Build has FAILED

Patch application report for D5649 (id=20168)

Rebasing onto 6b0cce3cd2...

Current branch diff-target is up to date.

Changes applied before test

commit fde7413968ad84f5c47b5e55d2662b4250c60eae
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Apr 29 17:36:46 2021 +0200

    identifiers: Add support for resolving core SWHID with uppercase chars
    
    Related to T3298

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/748/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/748/console

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 29 2021, 5:48 PM

Harbormaster failed remote builds in B21157: Diff 20168!

Build is green

Patch application report for D5649 (id=20168)

Rebasing onto 6b0cce3cd2...

Current branch diff-target is up to date.

Changes applied before test

commit fde7413968ad84f5c47b5e55d2662b4250c60eae
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Apr 29 17:36:46 2021 +0200

    identifiers: Add support for resolving core SWHID with uppercase chars
    
    Related to T3298

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/749/ for more details.

Harbormaster completed remote builds in B21157: Diff 20168.Apr 29 2021, 5:58 PM

anlambert requested review of this revision.Apr 29 2021, 5:58 PM