Page MenuHomeSoftware Heritage

identifiers: Add support for resolving core SWHID with uppercase chars
ClosedPublic

Authored by anlambert on Thu, Apr 29, 5:41 PM.

Details

Summary

The following SWHIDs will now be resolved without error:

SWH:1:CNT:9BC077A025CBA4C5B3628B0EABB4D3AAC0F35C63

SWH:1:CNT:9BC077A025CBA4C5B3628B0EABB4D3AAC0F35C63;origin=https://github.com/git/git

Related to T3298

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build has FAILED

Patch application report for D5649 (id=20168)

Rebasing onto 6b0cce3cd2...

Current branch diff-target is up to date.
Changes applied before test
commit fde7413968ad84f5c47b5e55d2662b4250c60eae
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Apr 29 17:36:46 2021 +0200

    identifiers: Add support for resolving core SWHID with uppercase chars
    
    Related to T3298

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/748/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/748/console

Harbormaster returned this revision to the author for changes because remote builds failed.Thu, Apr 29, 5:48 PM
Harbormaster failed remote builds in B21157: Diff 20168!

Build is green

Patch application report for D5649 (id=20168)

Rebasing onto 6b0cce3cd2...

Current branch diff-target is up to date.
Changes applied before test
commit fde7413968ad84f5c47b5e55d2662b4250c60eae
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Apr 29 17:36:46 2021 +0200

    identifiers: Add support for resolving core SWHID with uppercase chars
    
    Related to T3298

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/749/ for more details.

ardumont added a subscriber: ardumont.

lgtm

swh/web/tests/browse/views/test_identifiers.py
40

What about making the gen_swhidgenerate indifferently upper and lower (at least one of each) case swhid?

This revision is now accepted and ready to land.Fri, Apr 30, 9:52 AM
swh/web/tests/browse/views/test_identifiers.py
40

gen_swhid uses the QualifiedSWHID class under the hood so this will not work and we do not want to promote SWHID v1 with uppercase chars in it.

swh/web/tests/browse/views/test_identifiers.py
40

ack