Active Operations
Details
Diff Detail
- Repository
- rDSTO Storage manager
- Branch
- doc-metadata-providers
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 2322 Build 2816: tox-on-jenkins Jenkins Build 2815: arc lint + arc unit
Event Timeline
Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/42/ for more details.
Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/43/ for more details.
Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/44/ for more details.
swh/storage/storage.py | ||
---|---|---|
1295 | It might be pertinent to write a type example or the potential types list. |
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/60/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/60/console
swh/storage/storage.py | ||
---|---|---|
1295 | I'll go one step further:
Also, there should somewhere a description of what this metadata object stands for. I guess it is the metadata describing the metadata provider (which might be source of confusion; which metadata are we talking about in there?) |
swh/storage/storage.py | ||
---|---|---|
1295 | tbh, I don't know the answers to these questions |
I'm not sure why the build is failing.
Can I relaunch a build as a reviewer, or only by changing the diff will the build be relaunched?
swh/storage/storage.py | |||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
1295 |
It isn't a limited list for now, we have at the moment only one provider_type deposit_client, but the metadata provider entity should be used in the following future cases:
Because it is not implemented, I'm not sure if we should list the types above in the docs
Here is the actual metadata_provider in the storage today
with the use cases I mentioned we could add:
You are right ! we do not use at the moment the metadata property for a metadata_provider, this property was added for registries where we want to keep more information about the registry itself. @vlorentz you can add the existing hal deposit_client example as is For a larger discussion: |
Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/77/ for more details.