Add basic support for an origin blocklist
ClosedPublic
Actions

Authored by olasd on Apr 8 2021, 5:03 PM.

Details

Reviewers

vlorentz
ardumont

Maniphest Tasks

T3224: Implement blocklist support in swh.search

Commits

rDSEAebee5d1ba6b3: Add basic support for an origin blocklist

Summary

This adds a boolean field, "blocklisted", to the origin documents. When
this field is true, the documents are not returned in search results.

The blocklist field is sticky for updates, meaning that another run of the
swh.search journal client (or further visits of the origin) will keep
the origin hidden from search results.

Related to T3224.

Test Plan

Added tests for the new behavior

Diff Detail

Repository

rDSEA Archive search

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Apr 8 2021, 5:03 PM

Build is green

Patch application report for D5465 (id=19515)

Rebasing onto 7b3b0dca9d...

Current branch diff-target is up to date.

Changes applied before test

commit ebee5d1ba6b36616accd176159f130a152b0617a
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Thu Apr 8 16:49:35 2021 +0200

    Add basic support for an origin blocklist
    
    This adds a boolean field, "blocklisted", to the origin documents. When
    this field is true, the documents are not returned in search results.
    
    The blocklist field is sticky for updates, meaning that another run of the
    swh.search journal client (or further visits of the origin) will keep
    the origin hidden from search results.

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/105/ for more details.

Harbormaster completed remote builds in B20552: Diff 19515.Apr 8 2021, 5:05 PM

olasd requested review of this revision.Apr 8 2021, 5:05 PM

ardumont accepted this revision.Apr 8 2021, 5:13 PM

This revision is now accepted and ready to land.Apr 8 2021, 5:13 PM

vlorentz accepted this revision.Apr 8 2021, 5:35 PM

Closed by commit rDSEAebee5d1ba6b3: Add basic support for an origin blocklist (authored by olasd). · Explain WhyApr 8 2021, 5:37 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDSEAebee5d1ba6b3: Add basic support for an origin blocklist.