This contains the basic, from creating files to getting a working
(but untested and inefficient) loader.
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Maniphest Tasks
- T3153: Create "howto" / tutorials in the developer documentation
- Commits
- rDLDBASE0eeb712bb162: Start writing a package loader tutorial.
Diff Detail
- Repository
- rDLDBASE Generic VCS/Package Loader
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 20407 Build 31670: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 31669: arc lint + arc unit
Event Timeline
Build is green
Patch application report for D5401 (id=19328)
Rebasing onto ec5a76c6d9...
Current branch diff-target is up to date.
Changes applied before test
commit 12a64b87f040fa455650dedb1c0080159fc6714d Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Thu Apr 1 14:14:05 2021 +0200 Start writing a package loader tutorial. This contains the basic, from creating files to getting a working (but untested and inefficient) loader.
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/457/ for more details.
docs/package-loader-tutorial.rst | ||
---|---|---|
20 | both wordings are correct |
Build is green
Patch application report for D5401 (id=19348)
Rebasing onto ec5a76c6d9...
Current branch diff-target is up to date.
Changes applied before test
commit 309d831cf1cac10622c9434f06a7e8cd02b1ef5c Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Thu Apr 1 14:14:05 2021 +0200 Start writing a package loader tutorial. This contains the basic, from creating files to getting a working (but untested and inefficient) loader.
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/458/ for more details.
docs/package-loader-tutorial.rst | ||
---|---|---|
107 | this sentence sounds strange to me. Thee optional field ``url``, if provided, must be an URL where to download the filename. Please, provide it when relevant/possible. |
Thanks.
That documentation start looks good to me. A few suggestions inline.
I'll take that the TODOs will be done incrementally in future diffs.
So you can go ahead and merge it if you wish to.
docs/package-loader-tutorial.rst | ||
---|---|---|
107 | that sentence is clearly missing some words, let me fix it :p |
Build is green
Patch application report for D5401 (id=19349)
Rebasing onto ec5a76c6d9...
Current branch diff-target is up to date.
Changes applied before test
commit 0eeb712bb1620df4075b8f7057f86abe4fd149aa Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Thu Apr 1 14:14:05 2021 +0200 Start writing a package loader tutorial. This contains the basic, from creating files to getting a working (but untested and inefficient) loader.
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/459/ for more details.