HgLoaderFromDisk: Don't query revision_get with release ids
ClosedPublic
Actions

Authored by vlorentz on Mar 29 2021, 2:09 PM.

Details

Reviewers

Alphare
ardumont

Group Reviewers

Reviewers

Commits

rDLDHG428d764c403c: HgLoaderFromDisk: Don't query revision_get with release ids

Summary

This is a minor performance optimization, removing items from the
call to revision_get when we know their result will be None.

Motivation: A future commit (T3140) will refactor this function,
and dealing only with revision ids makes it simpler.

Diff Detail

Repository

rDLDHG Mercurial loader

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 20329
Build 31560: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 31559: arc lint + arc unit

Event Timeline

vlorentz created this revision.Mar 29 2021, 2:09 PM

vlorentz added a child revision: D5371: HgLoaderFromDisk: Read and write ExtIDs to find revisions already loaded.

Build is green

Patch application report for D5369 (id=19242)

Rebasing onto a62318d725...

Current branch diff-target is up to date.

Changes applied before test

commit 69f4b023b3ecf21e23838a46935069245dcfd118
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Mar 29 12:34:36 2021 +0200

    HgLoaderFromDisk: Don't query revision_get with release ids
    
    This is a minor performance optimization, removing items from the
    call to revision_get when we know their result will be None.
    
    Motivation: A future commit will refactor this function, and dealing only
    with revision ids makes it simpler.

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/187/ for more details.

Harbormaster completed remote builds in B20313: Diff 19242.Mar 29 2021, 2:11 PM

vlorentz requested review of this revision.Mar 29 2021, 2:11 PM

lgtm

and, right, I did not realize...

.oO(wondering if we do not reproduce this elsewhere now...)

This revision is now accepted and ready to land.Mar 29 2021, 5:03 PM

Alphare accepted this revision.Mar 29 2021, 5:52 PM

rebase

Build is green

Patch application report for D5369 (id=19261)

Rebasing onto 020791c464...

Current branch diff-target is up to date.

Changes applied before test

commit 428d764c403c4d69c802e989bc5cf001b614921e
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Mar 29 12:34:36 2021 +0200

    HgLoaderFromDisk: Don't query revision_get with release ids
    
    This is a minor performance optimization, removing items from the
    call to revision_get when we know their result will be None.
    
    Motivation: A future commit will refactor this function, and dealing only
    with revision ids makes it simpler.

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/194/ for more details.

Harbormaster completed remote builds in B20329: Diff 19261.Mar 30 2021, 9:44 AM

Closed by commit rDLDHG428d764c403c: HgLoaderFromDisk: Don't query revision_get with release ids (authored by vlorentz). · Explain WhyMar 30 2021, 9:46 AM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDLDHG428d764c403c: HgLoaderFromDisk: Don't query revision_get with release ids.