Page MenuHomeSoftware Heritage

HgLoaderFromDisk: Don't query revision_get with release ids
ClosedPublic

Authored by vlorentz on Mon, Mar 29, 2:09 PM.

Details

Summary

This is a minor performance optimization, removing items from the
call to revision_get when we know their result will be None.

Motivation: A future commit (T3140) will refactor this function,
and dealing only with revision ids makes it simpler.

Diff Detail

Repository
rDLDHG Mercurial loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D5369 (id=19242)

Rebasing onto a62318d725...

Current branch diff-target is up to date.
Changes applied before test
commit 69f4b023b3ecf21e23838a46935069245dcfd118
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Mar 29 12:34:36 2021 +0200

    HgLoaderFromDisk: Don't query revision_get with release ids
    
    This is a minor performance optimization, removing items from the
    call to revision_get when we know their result will be None.
    
    Motivation: A future commit will refactor this function, and dealing only
    with revision ids makes it simpler.

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/187/ for more details.

ardumont added a subscriber: ardumont.

lgtm

and, right, I did not realize...

.oO(wondering if we do not reproduce this elsewhere now...)

This revision is now accepted and ready to land.Mon, Mar 29, 5:03 PM

Build is green

Patch application report for D5369 (id=19261)

Rebasing onto 020791c464...

Current branch diff-target is up to date.
Changes applied before test
commit 428d764c403c4d69c802e989bc5cf001b614921e
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Mar 29 12:34:36 2021 +0200

    HgLoaderFromDisk: Don't query revision_get with release ids
    
    This is a minor performance optimization, removing items from the
    call to revision_get when we know their result will be None.
    
    Motivation: A future commit will refactor this function, and dealing only
    with revision ids makes it simpler.

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/194/ for more details.