Page MenuHomeSoftware Heritage

identifiers: Remove the deprecated SWHID class
ClosedPublic

Authored by vlorentz on Mar 3 2021, 10:45 AM.

Details

Summary

Other packages don't use it anymore.

Depends on D5189

Diff Detail

Repository
rDMOD Data model
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19628
Build 30460: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 30459: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D5190 (id=18549)

Could not rebase; Attempt merge onto 8e0119962b...

Updating 8e01199..bf4ab43
Fast-forward
 swh/model/cli.py                    |  92 ++++++-----
 swh/model/identifiers.py            | 190 +--------------------
 swh/model/tests/test_cli.py         |   6 +-
 swh/model/tests/test_identifiers.py | 317 ------------------------------------
 4 files changed, 59 insertions(+), 546 deletions(-)
Changes applied before test
commit bf4ab4336f7b43d442988c47d3dd70bb82b595c5
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Mar 3 10:44:48 2021 +0100

    identifiers: Remove the deprecated SWHID class
    
    Other packages don't use it anymore.

commit 1e924e84198a895003d6f649b8e3471cd93a7c7b
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Mar 3 10:44:27 2021 +0100

    cli: stop using the deprecated SWHID class

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/272/ for more details.

This revision is now accepted and ready to land.Mar 3 2021, 11:07 AM