- Group Reviewers
- rDMOD1e924e84198a: cli: stop using the deprecated SWHID class
- rDMOD Data model
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
Build is green
Patch application report for D5189 (id=18548)
Rebasing onto 8e0119962b...
Current branch diff-target is up to date.
Changes applied before test
commit 1e924e84198a895003d6f649b8e3471cd93a7c7b Author: Valentin Lorentz <email@example.com> Date: Wed Mar 3 10:44:27 2021 +0100 cli: stop using the deprecated SWHID class
See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/271/ for more details.
Why changing the return type here ? You could avoid multiple calls to str() below by keeping the old behavior.
each function is called exactly one, and str() needs to happen either before returning or after; it doesn't make a difference.
I changed it because I prefer coercing to strings as late as possible.
Ah right, I misread the code. Nevertheless, I would have keep the string conversion in the functions but that's not a big deal anyway.