cli: stop using the deprecated SWHID class
ClosedPublic
Actions

Authored by vlorentz on Mar 3 2021, 10:44 AM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDMOD1e924e84198a: cli: stop using the deprecated SWHID class

Diff Detail

Repository

rDMOD Data model

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Mar 3 2021, 10:44 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 3 2021, 10:44 AM

vlorentz added a child revision: D5190: identifiers: Remove the deprecated SWHID class.Mar 3 2021, 10:45 AM

Build is green

Patch application report for D5189 (id=18548)

Rebasing onto 8e0119962b...

Current branch diff-target is up to date.

Changes applied before test

commit 1e924e84198a895003d6f649b8e3471cd93a7c7b
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Mar 3 10:44:27 2021 +0100

    cli: stop using the deprecated SWHID class

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/271/ for more details.

Harbormaster completed remote builds in B19627: Diff 18548.Mar 3 2021, 10:46 AM

vlorentz requested review of this revision.Mar 3 2021, 10:46 AM

anlambert added a subscriber: anlambert.Mar 3 2021, 12:02 PM

anlambert added inline comments.

swh/model/cli.py
98	Why changing the return type here ? You could avoid multiple calls to `str()` below by keeping the old behavior.

vlorentz added inline comments.Mar 3 2021, 12:50 PM

swh/model/cli.py
98	each function is called exactly one, and `str()` needs to happen either before returning or after; it doesn't make a difference. I changed it because I prefer coercing to strings as late as possible.