was completely off, but had no test, so...
Details
Details
- Reviewers
aeviso ardumont - Group Reviewers
Reviewers - Commits
- rDPROV5380ab8fbc0b: Fix the db initialization stack
Diff Detail
Diff Detail
- Repository
- rDPROV Provenance database
- Branch
- master
- Lint
Lint Skipped - Unit
Unit Tests Skipped - Build Status
Buildable 19606 Build 30421: arc lint + arc unit
Event Timeline
Comment Actions
looks like it's doing the job ;)
I was wondering if it would not be clearer to alter the schema at the end of the file
(or in a subsequent file). Kinda what's done for indexes.
\if :dbflavor_with_path alter table content_early_in_rev add column loc bigint not null; -- location of the content relative to the revision root directory comment on column content_early_in_rev.loc is 'Location of content in revision'; ... \end
But that would split the reading so let's keep it that way
¯\_(ツ)_/¯
Comment Actions
yeah I've been playing with this idea also; don't like too much the "dandling" comma dance...
Comment Actions
Build is green
Patch application report for D5172 (id=18528)
Rebasing onto 4bb53c1e45...
Current branch diff-target is up to date.
Changes applied before test
commit 5380ab8fbc0b166ebf92cdea00f59892f26adb31
Author: David Douard <david.douard@sdfa3.org>
Date: Mon Mar 1 14:39:40 2021 +0100
Fix the db initialization stack
was completely off, but had no test, so...See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/1/ for more details.