Page MenuHomeSoftware Heritage
Differential D5073

Refactor the ProvenanceDB classes
ClosedPublic
Actions

Authored by douardda on Feb 12 2021, 4:32 PM.

Details

Reviewers
aeviso
Group Reviewers
Reviewers
Commits
rDPROV36d94d1e6bcd: Refactor the ProvenanceDB classes
Summary
  • extract the common methods in a base class
  • rename them as ProvenanceWithPathDB and ProvenanceWithoutPathDB,
  • move everything in the swh/provenance/postgresql/ directory

Depends on D5072

Diff Detail

Repository
rDPROV Provenance database
Branch
refactorings
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 19356
Build 30014: arc lint + arc unit

Event Timeline

douardda created this revision.Feb 12 2021, 4:32 PM
Harbormaster completed remote builds in B19207: Diff 18099.Feb 12 2021, 4:32 PM
douardda requested review of this revision.Feb 12 2021, 4:32 PM
douardda retitled this revision from Refactor the ProvenanceDB classes to WIP Refactor the ProvenanceDB classes.Feb 12 2021, 5:33 PM
douardda updated this revision to Diff 18135.Feb 16 2021, 10:39 AM

rebase

Harbormaster completed remote builds in B19239: Diff 18135.Feb 16 2021, 10:40 AM
douardda updated this revision to Diff 18139.Feb 16 2021, 12:13 PM

rebase and fix tests

Harbormaster completed remote builds in B19243: Diff 18139.Feb 16 2021, 12:13 PM
douardda retitled this revision from WIP Refactor the ProvenanceDB classes to Refactor the ProvenanceDB classes.Feb 16 2021, 12:14 PM
douardda added reviewers: aeviso, Reviewers.
douardda updated this revision to Diff 18149.Feb 16 2021, 3:44 PM

rebase and fix db initialization in tests

Harbormaster completed remote builds in B19253: Diff 18149.Feb 16 2021, 3:44 PM
douardda added a child revision: D5083: Declare ArchiveInterface and ProvenanceInterface as Protocol.Feb 16 2021, 3:44 PM
douardda updated this revision to Diff 18157.Feb 16 2021, 5:33 PM

rebase

Harbormaster completed remote builds in B19261: Diff 18157.Feb 16 2021, 5:33 PM
aeviso accepted this revision.Feb 18 2021, 2:06 PM
This revision is now accepted and ready to land.Feb 18 2021, 2:06 PM
douardda updated this revision to Diff 18262.Feb 18 2021, 5:50 PM

rebased

Harbormaster completed remote builds in B19356: Diff 18262.Feb 18 2021, 5:50 PM
Closed by commit rDPROV36d94d1e6bcd: Refactor the ProvenanceDB classes (authored by douardda). · Explain WhyFeb 19 2021, 10:01 AM
This revision was automatically updated to reflect the committed changes.
douardda added a commit: rDPROV36d94d1e6bcd: Refactor the ProvenanceDB classes.

Revision Contents
Changeset List

PathSize
swh/
provenance/
10 lines
4 lines
postgresql/
192 lines
132 lines
postgresql/
postgresql_nopath/
129 lines
postgresql_nopath/
tests/
16 lines

Diff 18262

View Options

swh/provenance/__init__.py

Loading...
View Options

swh/provenance/cli.py

Loading...
View Options

swh/provenance/postgresql/provenance.py

Loading...
View Options

swh/provenance/postgresql/provenancedb_base.py

Loading...
View Options

swh/provenance/postgresql/provenancedb_with_path.py

Loading...
View Options

swh/provenance/postgresql/provenancedb_without_path.py

Loading...
View Options

swh/provenance/postgresql_nopath/__init__.py

Loading...
View Options

swh/provenance/postgresql_nopath/provenance.py

Loading...
View Options

swh/provenance/tests/conftest.py

Loading...
About · Developer information · Legal