api_route: Ensure never_cache is honored for all response status codes
ClosedPublic
Actions

Authored by anlambert on Feb 17 2021, 1:55 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T2774: Fix vault end-to-end check

Commits

rDWAPPS2fbbbb95ef8b: api_route: Ensure never_cache is honored for all response status codes

Summary

Previously never cache headers were only added for responses with status code
200 but error responses must also be considered.

So move never_cache parameter handling of api_route decorator from apiurls
module to apiresponse one.

Related to T2774

Diff Detail

Repository

rDWAPPS Web applications

Branch

fix-never-cache-error-responses

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 19294
Build 29921: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 29920: arc lint + arc unit

Event Timeline

anlambert created this revision.Feb 17 2021, 1:55 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 17 2021, 1:55 PM

Build has FAILED

Patch application report for D5094 (id=18188)

Rebasing onto 113957105c...

Current branch diff-target is up to date.

Changes applied before test

commit eecf55400525d38c1a93508ba3694ad2837100db
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Feb 17 13:49:48 2021 +0100

    api_route: Ensure never_cache is honored for all response status codes
    
    Previously never cache headers were only added for responses with status code
    200 but error responses must also be considered.
    
    So move never_cache parameter handling of api_route decorator from apiurls
    module to apiresponse one.
    
    Related to T2774

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/573/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/573/console

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 17 2021, 1:58 PM

Harbormaster failed remote builds in B19289: Diff 18188!

Diff failing not due to the change but due to D5093
(should fix this provided D5077 is landed/released first)

Thanks.
lgtm.

Rebase

Build is green

Patch application report for D5094 (id=18193)

Rebasing onto 2e0ccea86a...

Current branch diff-target is up to date.

Changes applied before test

commit 2fbbbb95ef8b582f48efe189d46f0fe0d613e5dd
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Feb 17 13:49:48 2021 +0100

    api_route: Ensure never_cache is honored for all response status codes
    
    Previously never cache headers were only added for responses with status code
    200 but error responses must also be considered.
    
    So move never_cache parameter handling of api_route decorator from apiurls
    module to apiresponse one.
    
    Related to T2774

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/575/ for more details.

Harbormaster completed remote builds in B19294: Diff 18193.Feb 17 2021, 3:31 PM

anlambert requested review of this revision.Feb 17 2021, 3:31 PM

ardumont accepted this revision.Feb 17 2021, 3:57 PM

This revision is now accepted and ready to land.Feb 17 2021, 3:57 PM

Closed by commit rDWAPPS2fbbbb95ef8b: api_route: Ensure never_cache is honored for all response status codes (authored by anlambert). · Explain WhyFeb 17 2021, 4:00 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS2fbbbb95ef8b: api_route: Ensure never_cache is honored for all response status codes.