Previously never cache headers were only added for responses with status code
200 but error responses must also be considered.
So move never_cache parameter handling of api_route decorator from apiurls
module to apiresponse one.
Related to T2774
Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Maniphest Tasks
- T2774: Fix vault end-to-end check
- Commits
- rDWAPPS2fbbbb95ef8b: api_route: Ensure never_cache is honored for all response status codes
Diff Detail
Diff Detail
- Repository
- rDWAPPS Web applications
- Branch
- fix-never-cache-error-responses
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 19289 Build 29914: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 29913: arc lint + arc unit
| Time | Test | |
|---|---|---|
| 0 ms | Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.api.test_apiresponse .tox/py3/lib/python3.7/site-packages/swh/web/tests/api/test_apiresponse.py:156: in <module>
@given(content(), directory(), revision())
.tox/py3/lib/python3.7/site-packages/swh/web/tests/strategies.py:91: in content
| |
| 0 ms | Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.api.test_utils .tox/py3/lib/python3.7/site-packages/swh/web/tests/api/test_utils.py:110: in <module>
@given(release())
.tox/py3/lib/python3.7/site-packages/swh/web/tests/strategies.py:350: in release
| |
| 0 ms | Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.api.views.test_content .tox/py3/lib/python3.7/site-packages/swh/web/tests/api/views/test_content.py:20: in <module>
@given(content())
.tox/py3/lib/python3.7/site-packages/swh/web/tests/strategies.py:91: in content
| |
| 0 ms | Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.api.views.test_directory .tox/py3/lib/python3.7/site-packages/swh/web/tests/api/views/test_directory.py:17: in <module>
@given(directory())
.tox/py3/lib/python3.7/site-packages/swh/web/tests/strategies.py:223: in directory
| |
| 0 ms | Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.api.views.test_graph .tox/py3/lib/python3.7/site-packages/swh/web/tests/api/views/test_graph.py:168: in <module>
@given(origin())
.tox/py3/lib/python3.7/site-packages/swh/web/tests/strategies.py:269: in origin
| |
| View Full Test Results (23 Failed) |
Event Timeline
Comment Actions
Build has FAILED
Patch application report for D5094 (id=18188)
Rebasing onto 113957105c...
Current branch diff-target is up to date.
Changes applied before test
commit eecf55400525d38c1a93508ba3694ad2837100db
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date: Wed Feb 17 13:49:48 2021 +0100
api_route: Ensure never_cache is honored for all response status codes
Previously never cache headers were only added for responses with status code
200 but error responses must also be considered.
So move never_cache parameter handling of api_route decorator from apiurls
module to apiresponse one.
Related to T2774Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/573/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/573/console
Comment Actions
Build is green
Patch application report for D5094 (id=18193)
Rebasing onto 2e0ccea86a...
Current branch diff-target is up to date.
Changes applied before test
commit 2fbbbb95ef8b582f48efe189d46f0fe0d613e5dd
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date: Wed Feb 17 13:49:48 2021 +0100
api_route: Ensure never_cache is honored for all response status codes
Previously never cache headers were only added for responses with status code
200 but error responses must also be considered.
So move never_cache parameter handling of api_route decorator from apiurls
module to apiresponse one.
Related to T2774See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/575/ for more details.