Differential D5020

db: Unify sql joins on origin_visit_status using "USING"
ClosedPublic
Actions

Authored by ardumont on Feb 4 2021, 5:41 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDSTOd30ca9383965: db: Unify sql joins on origin_visit_status using "USING"

Summary

Depends on D5019

Diff Detail

Repository

rDSTO Storage manager

Branch

master

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 19029
Build 29488: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 29487: arc lint + arc unit

Event Timeline

ardumont created this revision.Feb 4 2021, 5:41 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 4 2021, 5:41 PM

ardumont added a child revision: D5021: storage: Refactor OriginVisitStatus instantiation.Feb 4 2021, 5:41 PM

Build is green

Patch application report for D5020 (id=17897)

Could not rebase; Attempt merge onto 9a9f234e0a...

Updating 9a9f234e..4b4f423b
Fast-forward
 sql/upgrades/167.sql          | 11 +++++++++++
 swh/storage/backfill.py       | 10 ++--------
 swh/storage/postgresql/db.py  | 18 ++++++------------
 swh/storage/sql/30-schema.sql |  4 ++--
 4 files changed, 21 insertions(+), 22 deletions(-)
 create mode 100644 sql/upgrades/167.sql

Changes applied before test

commit 4b4f423bf571ce3c625c5feb1733b189e1a25877
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Feb 4 17:11:18 2021 +0100

    db: Unify sql joins on origin_visit_status using "USING"

commit 3ad3ac12d46285bb1befd91806f4986b74da7812
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Feb 4 17:08:33 2021 +0100

    storage.postgresql: Use origin_visit_status.type value as source
    
    This stops using the origin_visit.type as fallback values as now, the database has been
    migrated.
    
    So this makes the origin_visit_status.type a not nullable column.
    
    This also drops now redundant join instructions on origin_visit table when reading.
    
    Related to T2968

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1127/ for more details.

Harbormaster completed remote builds in B19016: Diff 17897.Feb 4 2021, 5:50 PM

ardumont requested review of this revision.Feb 4 2021, 5:50 PM

vlorentz accepted this revision.Feb 5 2021, 9:53 AM

This revision is now accepted and ready to land.Feb 5 2021, 9:53 AM

Rebase

Build was aborted

Patch application report for D5020 (id=17910)

Could not rebase; Attempt merge onto efd8815b89...

Updating efd8815b..37df1a5c
Fast-forward
 sql/upgrades/167.sql          | 11 +++++++++++
 swh/storage/backfill.py       | 10 ++--------
 swh/storage/postgresql/db.py  | 18 ++++++------------
 swh/storage/sql/30-schema.sql |  4 ++--
 4 files changed, 21 insertions(+), 22 deletions(-)
 create mode 100644 sql/upgrades/167.sql

Changes applied before test

commit 37df1a5c75a5cd7528b9f155cb184e9b5a6d1cfa
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Feb 4 17:11:18 2021 +0100

    db: Unify sql joins on origin_visit_status using "USING"

commit 67bc71ddd9d59a21fb4e5270f29d9cb67d0f711a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Feb 4 17:08:33 2021 +0100

    storage.postgresql: Use origin_visit_status.type value as source
    
    This stops using the origin_visit.type as fallback values as now, the database has been
    migrated.
    
    So this makes the origin_visit_status.type a not nullable column.
    
    This also drops now redundant join instructions on origin_visit table when reading.
    
    Related to T2968

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1132/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1132/console

Harbormaster failed remote builds in B19029: Diff 17910!Feb 5 2021, 11:56 AM

Rebase

Build is green

Patch application report for D5020 (id=18008)

Could not rebase; Attempt merge onto 51df58e82e...

Updating 51df58e8..d30ca938
Fast-forward
 sql/upgrades/167.sql          | 11 +++++++++++
 swh/storage/backfill.py       | 10 ++--------
 swh/storage/postgresql/db.py  | 18 ++++++------------
 swh/storage/sql/30-schema.sql |  4 ++--
 4 files changed, 21 insertions(+), 22 deletions(-)
 create mode 100644 sql/upgrades/167.sql

Changes applied before test

commit d30ca93839655c1d1310a529dc8df3568afcab2f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Feb 4 17:11:18 2021 +0100

    db: Unify sql joins on origin_visit_status using "USING"

commit 046fe57c15f39e0f94cfbbb46c644a782833281c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Feb 4 17:08:33 2021 +0100

    storage.postgresql: Use origin_visit_status.type value as source
    
    This stops using the origin_visit.type as fallback values as now, the database has been
    migrated.
    
    So this makes the origin_visit_status.type a not nullable column.
    
    This also drops now redundant join instructions on origin_visit table when reading.
    
    Related to T2968

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1152/ for more details.

Harbormaster completed remote builds in B19128: Diff 18008.Feb 9 2021, 5:31 PM

Closed by commit rDSTOd30ca9383965: db: Unify sql joins on origin_visit_status using "USING" (authored by ardumont). · Explain WhyFeb 9 2021, 5:32 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSTOd30ca9383965: db: Unify sql joins on origin_visit_status using "USING".