This explicitely checks for the presence of swh:origin_to_add or swh:create_origin
within the provided metadata file.
If not present, this logs a warning about it.
Related to T2860
Paths
| Differential D4936 Authored by ardumont on Jan 25 2021, 12:33 PM.
Details
Summary This explicitely checks for the presence of swh:origin_to_add or swh:create_origin If not present, this logs a warning about it. Related to T2860
Diff Detail
Event TimelineHerald added a reviewer: Reviewers. · View Herald TranscriptJan 25 2021, 12:33 PM2021-01-25 12:33:29 (UTC+1) Harbormaster completed remote builds in B18684: Diff 17551.Jan 25 2021, 12:36 PM2021-01-25 12:36:02 (UTC+1) Comment Actions Build is green Patch application report for D4936 (id=17551)Rebasing onto b65694973e... Current branch diff-target is up to date. Changes applied before testcommit 3eb7840a32eec961d072b2a8807a08bd0c110855 Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Mon Jan 25 12:32:15 2021 +0100 deposit.cli: Warn users when missing origin tags are detected This explicitely checks for the presence of swh:origin_to_add or swh:create_origin within the provided metadata file. If not present, this logs a warning about it. Related to T2860 See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/531/ for more details. vlorentz added inline comments. This revision now requires changes to proceed.Jan 25 2021, 3:44 PM2021-01-25 15:44:56 (UTC+1)
Comment Actions Build is green Patch application report for D4936 (id=17587)Rebasing onto b65694973e... Current branch diff-target is up to date. Changes applied before testcommit c841f8b473594f6748d933dfe57bb815ac3a8bf1 Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Mon Jan 25 12:32:15 2021 +0100 deposit.cli: Warn users when missing origin tags are detected This explicitely checks for the presence of swh:origin_to_add or swh:create_origin within the provided metadata file. If not present, this logs a warning about it. Related to T2860 See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/532/ for more details. Harbormaster completed remote builds in B18725: Diff 17587.Jan 25 2021, 4:06 PM2021-01-25 16:06:15 (UTC+1) Comment Actions sorry, I didn't mean merging the non-error test with the error test, but to merge the non-error assertion with other tests (ie. the one that already don't trigger errors) Comment Actions
the funny thing is that i understood it that way initially... Comment Actions
What you suggest sounds good but it's hellishly annoying to do in the current state...
Comment Actions Adapt according to review Only adapted 2 nominal scenarios with it. I kept the last failing scenario as it also tests the add_to_origin (and we had none This caught a bug in the metadata generation about the <create_origin> case. It was Comment Actions Build is green Patch application report for D4936 (id=17680)Rebasing onto b65694973e... Current branch diff-target is up to date. Changes applied before testcommit 4deee5ba948ba6cb6760772b235371eace4c9690 Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Mon Jan 25 12:32:15 2021 +0100 deposit.cli: Warn users when missing origin tags are detected This explicitely checks for the presence of swh:origin_to_add or swh:create_origin within the provided metadata file. If not present, this logs a warning about it. Related to T2860 See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/533/ for more details. Harbormaster completed remote builds in B18821: Diff 17680.Jan 27 2021, 5:51 PM2021-01-27 17:51:23 (UTC+1) This revision is now accepted and ready to land.Feb 1 2021, 3:51 PM2021-02-01 15:51:39 (UTC+1) Closed by commit rDDEP4deee5ba948b: deposit.cli: Warn users when missing origin tags are detected (authored by ardumont). · Explain WhyFeb 1 2021, 4:55 PM2021-02-01 16:55:59 (UTC+1) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 17551 swh/deposit/cli/client.py
swh/deposit/tests/cli/test_client.py
|
why does that change?