model/ListedOrigin: Set extra_loader_arguments type to Dict[str, Any]
ClosedPublic
Actions

Authored by anlambert on Jan 22 2021, 11:30 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T2979: Port debian lister to the new Lister API

Commits

rDSCH2906b4e8a085: model/ListedOrigin: Set extra_loader_arguments type to Dict[str, Any]

Summary

Some loaders, for instance the debian one, can have non string arguments
so change the extra_loader_arguments type of the ListedOrigin model to
something more generic.

Related to T2979

Diff Detail

Repository

rDSCH Scheduling utilities

Branch

extra-loader-args-typing

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 18646
Build 28850: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 28849: arc lint + arc unit

Event Timeline

anlambert created this revision.Jan 22 2021, 11:30 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 22 2021, 11:30 AM

Build is green

Patch application report for D4924 (id=17514)

Rebasing onto 03460207a1...

Current branch diff-target is up to date.

Changes applied before test

commit 366ae9cec18cbecb8c4bce3223e790365ee3d64c
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Jan 22 11:24:49 2021 +0100

    model/ListedOrigin: Set extra_loader_arguments type to Dict[str, Any]
    
    Some loaders, for instance the debian one, can have non string arguments
    so change the extra_loader_arguments type of the ListedOrigin model to
    something more generic.
    
    Related to T2979

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/254/ for more details.

Harbormaster completed remote builds in B18646: Diff 17514.Jan 22 2021, 11:36 AM

anlambert requested review of this revision.Jan 22 2021, 11:36 AM

anlambert added a child revision: D4925: debian: Reimplement lister using new Lister API.Jan 22 2021, 12:18 PM

anlambert mentioned this in D4925: debian: Reimplement lister using new Lister API.Jan 22 2021, 12:27 PM

ardumont accepted this revision.Jan 22 2021, 5:15 PM

This revision is now accepted and ready to land.Jan 22 2021, 5:15 PM

Rebase

Build is green

Patch application report for D4924 (id=17562)

Rebasing onto 3d13cda421...

Current branch diff-target is up to date.

Changes applied before test

commit 2906b4e8a08517f5e3d86272232ad8ba926a43d7
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Jan 22 11:24:49 2021 +0100

    model/ListedOrigin: Set extra_loader_arguments type to Dict[str, Any]
    
    Some loaders, for instance the debian one, can have non string arguments
    so change the extra_loader_arguments type of the ListedOrigin model to
    something more generic.
    
    Related to T2979

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/270/ for more details.

Harbormaster completed remote builds in B18697: Diff 17562.Jan 25 2021, 2:13 PM

Closed by commit rDSCH2906b4e8a085: model/ListedOrigin: Set extra_loader_arguments type to Dict[str, Any] (authored by anlambert). · Explain WhyJan 25 2021, 2:19 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDSCH2906b4e8a085: model/ListedOrigin: Set extra_loader_arguments type to Dict[str, Any].