Page MenuHomeSoftware Heritage

model/ListedOrigin: Set extra_loader_arguments type to Dict[str, Any]
ClosedPublic

Authored by anlambert on Jan 22 2021, 11:30 AM.

Details

Summary

Some loaders, for instance the debian one, can have non string arguments
so change the extra_loader_arguments type of the ListedOrigin model to
something more generic.

Related to T2979

Diff Detail

Repository
rDSCH Scheduling utilities
Branch
extra-loader-args-typing
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18697
Build 28936: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 28935: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D4924 (id=17514)

Rebasing onto 03460207a1...

Current branch diff-target is up to date.
Changes applied before test
commit 366ae9cec18cbecb8c4bce3223e790365ee3d64c
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Jan 22 11:24:49 2021 +0100

    model/ListedOrigin: Set extra_loader_arguments type to Dict[str, Any]
    
    Some loaders, for instance the debian one, can have non string arguments
    so change the extra_loader_arguments type of the ListedOrigin model to
    something more generic.
    
    Related to T2979

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/254/ for more details.

This revision is now accepted and ready to land.Jan 22 2021, 5:15 PM

Build is green

Patch application report for D4924 (id=17562)

Rebasing onto 3d13cda421...

Current branch diff-target is up to date.
Changes applied before test
commit 2906b4e8a08517f5e3d86272232ad8ba926a43d7
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Jan 22 11:24:49 2021 +0100

    model/ListedOrigin: Set extra_loader_arguments type to Dict[str, Any]
    
    Some loaders, for instance the debian one, can have non string arguments
    so change the extra_loader_arguments type of the ListedOrigin model to
    something more generic.
    
    Related to T2979

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/270/ for more details.