They are already in the signature.
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Commits
- rDDEP43edd9039f23: Remove duplicate type annotations.
Diff Detail
- Repository
- rDDEP Push deposit
- Branch
- reorganize-sword
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 17225 Build 26591: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 26590: arc lint + arc unit
Event Timeline
Build has FAILED
Patch application report for D4514 (id=16007)
Could not rebase; Attempt merge onto dd1110b409...
Updating dd1110b4..d0eae061 Fast-forward swh/deposit/api/collection.py | 18 +- swh/deposit/api/common.py | 201 ++++++++++----------- swh/deposit/api/content.py | 17 +- swh/deposit/api/edit.py | 4 +- swh/deposit/api/edit_media.py | 5 +- swh/deposit/api/private/__init__.py | 11 +- swh/deposit/api/private/deposit_check.py | 4 +- swh/deposit/api/private/deposit_read.py | 4 +- swh/deposit/api/private/deposit_update_status.py | 6 +- swh/deposit/api/state.py | 17 +- swh/deposit/api/sword_edit.py | 18 +- .../api/test_deposit_private_read_metadata.py | 2 +- swh/deposit/tests/api/test_deposit_update.py | 6 +- 13 files changed, 140 insertions(+), 173 deletions(-)
Changes applied before test
commit d0eae061492aa157b9a2862e8130f16571eca8cc Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Wed Nov 18 16:31:09 2020 +0100 Remove duplicate type annotations. They are already in the signature. commit bacbc297319c972c01723561ba0ba48caa93133c Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Wed Nov 18 16:29:20 2020 +0100 Deduplicate handling of missing Deposit ids + add it where missing. commit 3205590ffe3836cdbf409fe5bbd9d28224ffe7d5 Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Wed Nov 18 16:04:29 2020 +0100 Use an attr class instead of a dict to carry receipt information. Better typing + deduplicates documentation.
Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/378/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/378/console
Build has FAILED
Patch application report for D4514 (id=16007)
Could not rebase; Attempt merge onto dd1110b409...
Updating dd1110b4..d0eae061 Fast-forward swh/deposit/api/collection.py | 18 +- swh/deposit/api/common.py | 201 ++++++++++----------- swh/deposit/api/content.py | 17 +- swh/deposit/api/edit.py | 4 +- swh/deposit/api/edit_media.py | 5 +- swh/deposit/api/private/__init__.py | 11 +- swh/deposit/api/private/deposit_check.py | 4 +- swh/deposit/api/private/deposit_read.py | 4 +- swh/deposit/api/private/deposit_update_status.py | 6 +- swh/deposit/api/state.py | 17 +- swh/deposit/api/sword_edit.py | 18 +- .../api/test_deposit_private_read_metadata.py | 2 +- swh/deposit/tests/api/test_deposit_update.py | 6 +- 13 files changed, 140 insertions(+), 173 deletions(-)
Changes applied before test
commit d0eae061492aa157b9a2862e8130f16571eca8cc Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Wed Nov 18 16:31:09 2020 +0100 Remove duplicate type annotations. They are already in the signature. commit bacbc297319c972c01723561ba0ba48caa93133c Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Wed Nov 18 16:29:20 2020 +0100 Deduplicate handling of missing Deposit ids + add it where missing. commit 3205590ffe3836cdbf409fe5bbd9d28224ffe7d5 Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Wed Nov 18 16:04:29 2020 +0100 Use an attr class instead of a dict to carry receipt information. Better typing + deduplicates documentation.
Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/379/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/379/console
Build has FAILED
Patch application report for D4514 (id=16017)
Rebasing onto bacbc29731...
Current branch diff-target is up to date.
Changes applied before test
commit d0eae061492aa157b9a2862e8130f16571eca8cc Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Wed Nov 18 16:31:09 2020 +0100 Remove duplicate type annotations. They are already in the signature.
Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/380/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/380/console
Build is green
Patch application report for D4514 (id=16018)
Rebasing onto bacbc29731...
Current branch diff-target is up to date.
Changes applied before test
commit 43edd9039f23a5ff449897ba7ff4c59ac3868197 Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Wed Nov 18 16:31:09 2020 +0100 Remove duplicate type annotations. They are already in the signature.
See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/381/ for more details.