Page MenuHomeSoftware Heritage

Deduplicate handling of missing Deposit ids + add it where missing.
ClosedPublic

Authored by vlorentz on Wed, Nov 18, 4:29 PM.

Diff Detail

Repository
rDDEP Push deposit
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Wed, Nov 18, 4:29 PM

Build is green

Patch application report for D4513 (id=16006)

Could not rebase; Attempt merge onto dd1110b409...

Updating dd1110b4..bacbc297
Fast-forward
 swh/deposit/api/collection.py                      |  18 +--
 swh/deposit/api/common.py                          | 178 ++++++++++-----------
 swh/deposit/api/content.py                         |  17 +-
 swh/deposit/api/edit.py                            |   4 +-
 swh/deposit/api/edit_media.py                      |   5 +-
 swh/deposit/api/private/__init__.py                |  11 +-
 swh/deposit/api/private/deposit_check.py           |   4 +-
 swh/deposit/api/private/deposit_read.py            |   4 +-
 swh/deposit/api/private/deposit_update_status.py   |   6 +-
 swh/deposit/api/state.py                           |  17 +-
 swh/deposit/api/sword_edit.py                      |  18 +--
 .../api/test_deposit_private_read_metadata.py      |   2 +-
 swh/deposit/tests/api/test_deposit_update.py       |   6 +-
 13 files changed, 127 insertions(+), 163 deletions(-)
Changes applied before test
commit bacbc297319c972c01723561ba0ba48caa93133c
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Nov 18 16:29:20 2020 +0100

    Deduplicate handling of missing Deposit ids + add it where missing.

commit 3205590ffe3836cdbf409fe5bbd9d28224ffe7d5
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Nov 18 16:04:29 2020 +0100

    Use an attr class instead of a dict to carry receipt information.
    
    Better typing + deduplicates documentation.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/377/ for more details.

ardumont accepted this revision.Thu, Nov 19, 9:34 AM
This revision is now accepted and ready to land.Thu, Nov 19, 9:34 AM